Replies: 7 comments 4 replies
-
Very good shout, thanks! I didn't know about this. I think it's worth the upgrade as well as doing the route v2 restructuring as 1.14.1 already warns about the folder based solution's deprecation. |
Beta Was this translation helpful? Give feedback.
-
Flat routes are really nice. They're also implemented in the repo above - although I've used https://github.com/kiliman/remix-flat-routes - which Michael kindly helped me with. The 'core' of Michael's repo is now in Remix, but I believe there are still a few features that are unique to Michael's repo - which he is going to continue to maintain. |
Beta Was this translation helpful? Give feedback.
-
Hey there - quick note to say I've not forgotten about this. Things went a bit bananas at this end. I think the V2 meta would be nice to start with. I'll try to get a PR over soon. |
Beta Was this translation helpful? Give feedback.
-
Okay so I finally found a few minutes to take a stab at the V2 meta changes, as well as wrote the 'bare minimum' unit test required for our metaMerge util. I've cloned the main project, and while this isn't 1:1 based on your readme, we do have a developer Auth0 account, and I've updated the .env settings - at least the ones that I'd hoped would let me run this locally - but I'm seeing the following error after starting the app with |
Beta Was this translation helpful? Give feedback.
-
Tried a couple of things - sigh. Apologies, but struggling to get a development environment working. Also this just landed - remix-run/remix#5785 - which means I'll have some changes to make when this is released. When they're in I'll post an update here with up-to-date links to my Oh and in the updates, there will be a link in the docs to a Gist that Ryan created for an alternative (and likely better?) mergeMeta helper method... https://gist.github.com/ryanflorence/ec1849c6d690cfbffcb408ecd633e069 |
Beta Was this translation helpful? Give feedback.
-
The docs are also much improved and summarize all changes well - including whether you need to merge meta or not... |
Beta Was this translation helpful? Give feedback.
-
I've just updated our public project. Here's how it looks...
Hope some of this helps ;-) |
Beta Was this translation helpful? Give feedback.
-
If you're interested in implementing V2 meta - the original discussion is here...
remix-run/remix#4462
I've also implemented this here on our own 'remix workbench' site - with an example here...
https://github.com/infonomic/remix.infonomic.io/blob/develop/app/routes/_app%2B/notes.%24noteId_.edit.tsx
We also created helper utils for
mergeMeta
andappendSiteTitle
which I think are okay - here...https://github.com/infonomic/remix.infonomic.io/blob/develop/app/utils/utils.ts
Hope this helps...
Beta Was this translation helpful? Give feedback.
All reactions