chore: Update CI to run tests on PHP 8.4 #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I'll re-run CI once 8.4 is released, then merge this (provided nothing comes up). |
|
Should be good now, reran on my fork and all looks good. Ready to re-check and merge whenever you have some time. |
meyfa
changed the title
|
Thanks for the reminder. LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.4 currently has RC4 out, actual release will be later this month. You may want to wait with merging this until 21-11-2024, although I suspect not much will change in the mean time that's relevant to this project.
Please note that
composer.jsonrequires no changes, hence a release for this PR will not be necessary as users will already be able to install latest release on PHP 8.4. This PR just makes sure future changes are also tested on PHP 8.4.