Skip to content

Document CI enforced msrv in readme and rust-version fields #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tobz merged 2 commits into from
Jul 6, 2022
Merged

Document CI enforced msrv in readme and rust-version fields #311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea7205c
Document CI enforced msrv in readme and rust-version fields
rukai Jul 5, 2022
fc97bce
review feedback
rukai Jul 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,17 @@ As well, there are also some community-maintained exporters and other integratio
* [`metrics-exporter-newrelic`][metrics-exporter-newrelic]: A `metrics`-compatible exporter for sending metrics to New Relic.
* [`opinionated_metrics`][opinionated-metrics]: Opinionated interface to emitting metrics for CLi/server applications, based on `metrics`.

## MSRV

Minimum Supported Rust version is **1.56.1**.
It is enforced in CI.

### policy for bumping MSRV

* The last 4 stable releases must always be supported
* Goal is to try and support older versions where possible (not opting in to newer versions just to use a new helper method on standard library types, etc)
* Do not bump the MSRV for newer versions of dependencies in core crates (metrics and metrics-util)

# contributing

To those of you who have already contributed to `metrics` in some way, shape, or form: **a big, and continued, "thank you!"** ❤️
Expand Down
1 change: 1 addition & 0 deletions metrics-benchmark/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ name = "metrics-benchmark"
version = "0.1.1-alpha.5"
authors = ["Toby Lawrence <toby@nuclearfurnace.com>"]
edition = "2018"
rust-version = "1.56.1"
publish = false

[dependencies]
Expand Down
1 change: 1 addition & 0 deletions metrics-exporter-prometheus/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ name = "metrics-exporter-prometheus"
version = "0.10.0"
authors = ["Toby Lawrence <toby@nuclearfurnace.com>"]
edition = "2018"
rust-version = "1.56.1"

license = "MIT"

Expand Down
1 change: 1 addition & 0 deletions metrics-exporter-tcp/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ name = "metrics-exporter-tcp"
version = "0.6.0"
authors = ["Toby Lawrence <toby@nuclearfurnace.com>"]
edition = "2018"
rust-version = "1.56.1"

license = "MIT"

Expand Down
1 change: 1 addition & 0 deletions metrics-macros/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ name = "metrics-macros"
version = "0.5.1"
authors = ["Toby Lawrence <toby@nuclearfurnace.com>"]
edition = "2018"
rust-version = "1.56.1"

license = "MIT"

Expand Down
1 change: 1 addition & 0 deletions metrics-observer/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ name = "metrics-observer"
version = "0.1.1-alpha.2"
authors = ["Toby Lawrence <toby@nuclearfurnace.com>"]
edition = "2018"
rust-version = "1.56.1"
publish = false

license = "MIT"
Expand Down
1 change: 1 addition & 0 deletions metrics-tracing-context/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ name = "metrics-tracing-context"
version = "0.11.0"
authors = ["MOZGIII <mike-n@narod.ru>"]
edition = "2018"
rust-version = "1.56.1"

license = "MIT"

Expand Down
1 change: 1 addition & 0 deletions metrics-util/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ name = "metrics-util"
version = "0.13.0"
authors = ["Toby Lawrence <toby@nuclearfurnace.com>"]
edition = "2018"
rust-version = "1.56.1"

license = "MIT"

Expand Down
1 change: 1 addition & 0 deletions metrics/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ name = "metrics"
version = "0.19.0"
authors = ["Toby Lawrence <toby@nuclearfurnace.com>"]
edition = "2018"
rust-version = "1.56.1"

license = "MIT"

Expand Down
1 change: 1 addition & 0 deletions tooling/metrics-histogram-fidelity/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ name = "metrics-histogram-fidelity"
version = "0.1.0"
authors = ["Toby Lawrence <toby@nuclearfurnace.com>"]
edition = "2018"
rust-version = "1.56.1"

[workspace]

Expand Down