[#203] make sci optional for smaller JS builds #210
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sci optional using the same mechanisms that clojure.spec uses to dynamically load test.check. Fixes #203.
sci.core
has to be required first. There's probably a kaocha preloads plugin which can do this. But the tests have to be adapted to the optionality of sci anyway.Note that sci users now have to bring in the sci dependency themselves. If they don't they will get an error message when using
malli.core/eval
.vs.