Skip to content

Conversation

@maxwhitemet
Copy link
Contributor

This PR updates the acceptance test data for batch 11, all calendar changes.

@maxwhitemet maxwhitemet changed the base branch from master to environment_upgrade_feature_branch July 8, 2025 12:45
@maxwhitemet maxwhitemet changed the title Batch 11 acceptance test data Acceptance test batch 11 Jul 8, 2025
@maxwhitemet maxwhitemet force-pushed the batch_11_acceptance_test_data branch from f024b8b to e3081de Compare July 8, 2025 12:54
Copy link
Contributor

@bayliffe bayliffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loads of significant changes in this set that need to be commented upon.

The comment here about the coordinate bounds is likely relevant to the changes to height_bnds in this data: #89 (comment)

The change to mosg__model_run also needs to be understood as the rounding appears to have changed here.

data/weighted_blending/model_spot/kgo.nc
DIFFER : VALUES OF GLOBAL ATTRIBUTE : mosg__model_run : gl_ens:20230522T1800Z:0.250
gl_ens:20230523T0000Z:0.250
uk_ens:20230523T0400Z:0.084
uk_ens:20230523T0500Z:0.084
uk_ens:20230523T0600Z:0.084
uk_ens:20230523T0700Z:0.084
uk_ens:20230523T0800Z:0.084
uk_ens:20230523T0900Z:0.084 <> gl_ens:20230522T1800Z:0.250
gl_ens:20230523T0000Z:0.250
uk_ens:20230523T0400Z:0.083
uk_ens:20230523T0500Z:0.083
uk_ens:20230523T0600Z:0.083
uk_ens:20230523T0700Z:0.083
uk_ens:20230523T0800Z:0.083
uk_ens:20230523T0900Z:0.083
DIFFER : LENGTHS : ATTRIBUTE : calendar : VARIABLE : blend_time : 9 <> 8 : VALUES : "gregorian" : "standard"
DIFFER : LENGTHS : ATTRIBUTE : calendar : VARIABLE : forecast_reference_time : 9 <> 8 : VALUES : "gregorian" : "standard"
DIFFER : LENGTHS : ATTRIBUTE : calendar : VARIABLE : time : 9 <> 8 : VALUES : "gregorian" : "standard"
=============================================
data/wet-bulb-temperature-integral/basic/with_id_attr/kgo.nc
DIFFER : LENGTHS : ATTRIBUTE : calendar : VARIABLE : forecast_reference_time : 9 <> 8 : VALUES : "gregorian" : "standard"
DIFFER : LENGTHS : ATTRIBUTE : calendar : VARIABLE : time : 9 <> 8 : VALUES : "gregorian" : "standard"
DIFFER : VARIABLE : wet_bulb_temperature_integral : POSITION : [5,0,16] : VALUES : 600.603 <> 600.603
DIFFER : VARIABLE : wet_bulb_temperature_integral : POSITION : [5,0,23] : VALUES : 557.058 <> 557.058
DIFFER : VARIABLE : wet_bulb_temperature_integral : POSITION : [5,0,25] : VALUES : 707.969 <> 707.969
DIFFER : VARIABLE : wet_bulb_temperature_integral : POSITION : [5,1,26] : VALUES : 542.873 <> 542.873
DIFFER : VARIABLE : wet_bulb_temperature_integral : POSITION : [5,2,27] : VALUES : 595.487 <> 595.487
DIFFER : VARIABLE : height_bnds : POSITION : [0,0] : VALUES : 1750 <> 2000
DIFFER : VARIABLE : height_bnds : POSITION : [0,1] : VALUES : 2000 <> 1750
DIFFER : VARIABLE : height_bnds : POSITION : [1,0] : VALUES : 1500 <> 1750
DIFFER : VARIABLE : height_bnds : POSITION : [1,1] : VALUES : 1750 <> 1500
DIFFER : VARIABLE : height_bnds : POSITION : [2,0] : VALUES : 1250 <> 1500
=============================================
data/wet-bulb-temperature-integral/basic/without_id_attr/kgo.nc
DIFFER : LENGTHS : ATTRIBUTE : calendar : VARIABLE : forecast_reference_time : 9 <> 8 : VALUES : "gregorian" : "standard"
DIFFER : LENGTHS : ATTRIBUTE : calendar : VARIABLE : time : 9 <> 8 : VALUES : "gregorian" : "standard"
DIFFER : VARIABLE : wet_bulb_temperature_integral : POSITION : [5,0,16] : VALUES : 600.603 <> 600.603
DIFFER : VARIABLE : wet_bulb_temperature_integral : POSITION : [5,0,23] : VALUES : 557.058 <> 557.058
DIFFER : VARIABLE : wet_bulb_temperature_integral : POSITION : [5,0,25] : VALUES : 707.969 <> 707.969
DIFFER : VARIABLE : wet_bulb_temperature_integral : POSITION : [5,1,26] : VALUES : 542.873 <> 542.873
DIFFER : VARIABLE : wet_bulb_temperature_integral : POSITION : [5,2,27] : VALUES : 595.487 <> 595.487
DIFFER : VARIABLE : height_bnds : POSITION : [0,0] : VALUES : 1750 <> 2000
DIFFER : VARIABLE : height_bnds : POSITION : [0,1] : VALUES : 2000 <> 1750
DIFFER : VARIABLE : height_bnds : POSITION : [1,0] : VALUES : 1500 <> 1750
DIFFER : VARIABLE : height_bnds : POSITION : [1,1] : VALUES : 1750 <> 1500
DIFFER : VARIABLE : height_bnds : POSITION : [2,0] : VALUES : 1250 <> 1500
=============================================
data/wet-bulb-temperature-integral/realizations/kgo.nc
DIFFER : LENGTHS : ATTRIBUTE : calendar : VARIABLE : forecast_reference_time : 9 <> 8 : VALUES : "gregorian" : "standard"
DIFFER : LENGTHS : ATTRIBUTE : calendar : VARIABLE : time : 9 <> 8 : VALUES : "gregorian" : "standard"
DIFFER : VARIABLE : height_bnds : POSITION : [0,0] : VALUES : 5500 <> 6000
DIFFER : VARIABLE : height_bnds : POSITION : [0,1] : VALUES : 6000 <> 5500
DIFFER : VARIABLE : height_bnds : POSITION : [1,0] : VALUES : 5000 <> 5500
DIFFER : VARIABLE : height_bnds : POSITION : [1,1] : VALUES : 5500 <> 5000
DIFFER : VARIABLE : height_bnds : POSITION : [2,0] : VALUES : 4500 <> 5000
=============================================
data/wet-bulb-temperature/basic/with_id_attr/kgo.nc
DIFFER : LENGTHS : ATTRIBUTE : calendar : VARIABLE : forecast_reference_time : 9 <> 8 : VALUES : "gregorian" : "standard"
DIFFER : LENGTHS : ATTRIBUTE : calendar : VARIABLE : time : 9 <> 8 : VALUES : "gregorian" : "standard"
DIFFER : VARIABLE : wet_bulb_temperature : POSITION : [0,28] : VALUES : 285.877 <> 285.878
DIFFER : VARIABLE : wet_bulb_temperature : POSITION : [0,30] : VALUES : 286.386 <> 286.386
DIFFER : VARIABLE : wet_bulb_temperature : POSITION : [0,32] : VALUES : 287.039 <> 287.039
DIFFER : VARIABLE : wet_bulb_temperature : POSITION : [0,38] : VALUES : 285.19 <> 285.19
DIFFER : VARIABLE : wet_bulb_temperature : POSITION : [0,41] : VALUES : 281.823 <> 281.823
=============================================
data/wet-bulb-temperature/basic/without_id_attr/kgo.nc
DIFFER : LENGTHS : ATTRIBUTE : calendar : VARIABLE : forecast_reference_time : 9 <> 8 : VALUES : "gregorian" : "standard"
DIFFER : LENGTHS : ATTRIBUTE : calendar : VARIABLE : time : 9 <> 8 : VALUES : "gregorian" : "standard"
DIFFER : VARIABLE : wet_bulb_temperature : POSITION : [0,12] : VALUES : 286.942 <> 286.942
DIFFER : VARIABLE : wet_bulb_temperature : POSITION : [0,30] : VALUES : 286.386 <> 286.386
DIFFER : VARIABLE : wet_bulb_temperature : POSITION : [0,45] : VALUES : 281.36 <> 281.36
DIFFER : VARIABLE : wet_bulb_temperature : POSITION : [1,0] : VALUES : 291.774 <> 291.774
DIFFER : VARIABLE : wet_bulb_temperature : POSITION : [1,2] : VALUES : 291.583 <> 291.583
=============================================
data/wet-bulb-temperature/global/kgo.nc
DIFFER : LENGTHS : ATTRIBUTE : calendar : VARIABLE : forecast_reference_time : 9 <> 8 : VALUES : "gregorian" : "standard"
DIFFER : LENGTHS : ATTRIBUTE : calendar : VARIABLE : time : 9 <> 8 : VALUES : "gregorian" : "standard"
DIFFER : VARIABLE : wet_bulb_temperature : POSITION : [2,37] : VALUES : 251.982 <> 251.982
DIFFER : VARIABLE : wet_bulb_temperature : POSITION : [3,12] : VALUES : 241.595 <> 241.595
DIFFER : VARIABLE : wet_bulb_temperature : POSITION : [3,35] : VALUES : 255.338 <> 255.338
DIFFER : VARIABLE : wet_bulb_temperature : POSITION : [9,32] : VALUES : 277.599 <> 277.599
DIFFER : VARIABLE : wet_bulb_temperature : POSITION : [9,46] : VALUES : 274.961 <> 274.961
=============================================
data/wet-bulb-temperature/multi_level/kgo.nc
DIFFER : LENGTHS : ATTRIBUTE : calendar : VARIABLE : forecast_reference_time : 9 <> 8 : VALUES : "gregorian" : "standard"
DIFFER : LENGTHS : ATTRIBUTE : calendar : VARIABLE : time : 9 <> 8 : VALUES : "gregorian" : "standard"
DIFFER : VARIABLE : wet_bulb_temperature : POSITION : [0,0,28] : VALUES : 278.988 <> 278.988
DIFFER : VARIABLE : wet_bulb_temperature : POSITION : [0,0,29] : VALUES : 279.868 <> 279.868
DIFFER : VARIABLE : wet_bulb_temperature : POSITION : [0,1,24] : VALUES : 280.506 <> 280.506
DIFFER : VARIABLE : wet_bulb_temperature : POSITION : [0,2,4] : VALUES : 280.129 <> 280.129
DIFFER : VARIABLE : wet_bulb_temperature : POSITION : [0,3,21] : VALUES : 280.145 <> 280.145
=============================================
data/wind_direction/basic/kgo.nc
DIFFER : LENGTHS : ATTRIBUTE : calendar : VARIABLE : forecast_reference_time : 9 <> 8 : VALUES : "gregorian" : "standard"
DIFFER : LENGTHS : ATTRIBUTE : calendar : VARIABLE : time : 9 <> 8 : VALUES : "gregorian" : "standard"
DIFFER : VARIABLE : wind_from_direction : POSITION : [0,4] : VALUES : 270.768 <> 270.768
DIFFER : VARIABLE : wind_from_direction : POSITION : [0,11] : VALUES : 277.05 <> 277.05
DIFFER : VARIABLE : wind_from_direction : POSITION : [0,14] : VALUES : 283.729 <> 283.729
DIFFER : VARIABLE : wind_from_direction : POSITION : [0,16] : VALUES : 270.454 <> 270.454
DIFFER : VARIABLE : wind_from_direction : POSITION : [0,18] : VALUES : 251.939 <> 251.939
=============================================
data/wind_direction/global/kgo.nc
DIFFER : LENGTHS : ATTRIBUTE : calendar : VARIABLE : forecast_reference_time : 9 <> 8 : VALUES : "gregorian" : "standard"
DIFFER : LENGTHS : ATTRIBUTE : calendar : VARIABLE : time : 9 <> 8 : VALUES : "gregorian" : "standard"
DIFFER : VARIABLE : wind_from_direction : POSITION : [0,22] : VALUES : 113.855 <> 113.855
DIFFER : VARIABLE : wind_from_direction : POSITION : [0,31] : VALUES : 62.0555 <> 62.0555
DIFFER : VARIABLE : wind_from_direction : POSITION : [0,36] : VALUES : 31.1407 <> 31.1407
DIFFER : VARIABLE : wind_from_direction : POSITION : [0,38] : VALUES : 18.3214 <> 18.3214
DIFFER : VARIABLE : wind_from_direction : POSITION : [0,40] : VALUES : 5.21022 <> 5.21022
=============================================
data/wind_downscaling/basic/kgo.nc
DIFFER : LENGTHS : ATTRIBUTE : calendar : VARIABLE : forecast_reference_time : 9 <> 8 : VALUES : "gregorian" : "standard"
DIFFER : LENGTHS : ATTRIBUTE : calendar : VARIABLE : time : 9 <> 8 : VALUES : "gregorian" : "standard"
DIFFER : VARIABLE : wind_speed : POSITION : [0,0,2] : VALUES : 7.26457 <> 7.26457
DIFFER : VARIABLE : wind_speed : POSITION : [0,0,15] : VALUES : 8.5911 <> 8.5911
DIFFER : VARIABLE : wind_speed : POSITION : [0,0,19] : VALUES : 9.61849 <> 9.61849
DIFFER : VARIABLE : wind_speed : POSITION : [0,0,52] : VALUES : 7.17777 <> 7.17777
DIFFER : VARIABLE : wind_speed : POSITION : [0,0,63] : VALUES : 6.39811 <> 6.39811
=============================================
data/wind_downscaling/single_level/kgo.nc
DIFFER : LENGTHS : ATTRIBUTE : calendar : VARIABLE : forecast_reference_time : 9 <> 8 : VALUES : "gregorian" : "standard"
DIFFER : LENGTHS : ATTRIBUTE : calendar : VARIABLE : time : 9 <> 8 : VALUES : "gregorian" : "standard"
DIFFER : VARIABLE : wind_speed : POSITION : [0,9] : VALUES : 10.8232 <> 10.8232
DIFFER : VARIABLE : wind_speed : POSITION : [0,52] : VALUES : 12.7531 <> 12.7531
DIFFER : VARIABLE : wind_speed : POSITION : [0,57] : VALUES : 12.5203 <> 12.5203
DIFFER : VARIABLE : wind_speed : POSITION : [0,89] : VALUES : 13.1495 <> 13.1495
DIFFER : VARIABLE : wind_speed : POSITION : [0,91] : VALUES : 13.5575 <> 13.5575
=============================================
data/wind_downscaling/veg/kgo.nc
DIFFER : LENGTHS : ATTRIBUTE : calendar : VARIABLE : forecast_reference_time : 9 <> 8 : VALUES : "gregorian" : "standard"
DIFFER : LENGTHS : ATTRIBUTE : calendar : VARIABLE : time : 9 <> 8 : VALUES : "gregorian" : "standard"
DIFFER : VARIABLE : wind_speed : POSITION : [0,0,2] : VALUES : 7.26457 <> 7.26457
DIFFER : VARIABLE : wind_speed : POSITION : [0,0,3] : VALUES : 7.67922 <> 7.67921
DIFFER : VARIABLE : wind_speed : POSITION : [0,0,4] : VALUES : 7.74773 <> 7.74773
DIFFER : VARIABLE : wind_speed : POSITION : [0,0,19] : VALUES : 10.2611 <> 10.2611
DIFFER : VARIABLE : wind_speed : POSITION : [0,0,20] : VALUES : 7.9431 <> 7.9431
=============================================
data/wind_downscaling/with_realization/kgo.nc
DIFFER : LENGTHS : ATTRIBUTE : calendar : VARIABLE : forecast_reference_time : 9 <> 8 : VALUES : "gregorian" : "standard"
DIFFER : LENGTHS : ATTRIBUTE : calendar : VARIABLE : time : 9 <> 8 : VALUES : "gregorian" : "standard"
DIFFER : VARIABLE : wind_speed : POSITION : [0,0,0,2] : VALUES : 7.26457 <> 7.26457
DIFFER : VARIABLE : wind_speed : POSITION : [0,0,0,15] : VALUES : 8.5911 <> 8.5911
DIFFER : VARIABLE : wind_speed : POSITION : [0,0,0,19] : VALUES : 9.61849 <> 9.61849
DIFFER : VARIABLE : wind_speed : POSITION : [0,0,0,52] : VALUES : 7.17777 <> 7.17777
DIFFER : VARIABLE : wind_speed : POSITION : [0,0,0,63] : VALUES : 6.39811 <> 6.39811

@maxwhitemet
Copy link
Contributor Author

maxwhitemet commented Jul 11, 2025

As suggested, the changes in height_bnds are likely due to the sort_coord_in_cube function in the orographic enhancement function, as described here (#89 (comment)).

The reason for the changes in decimal places, e.g. DIFFER : VARIABLE : wet_bulb_temperature : POSITION : [0,28] : VALUES : 285.877 <> 285.878, becomes clear when looking at the unrounded values, where the value is nudged to round up rather than down by precision changes.

Original New
285.877 285.878
285.87747 285.8775

The cause of the change in the blending weights is similar, with a max diff of ~2.14576721668 × 10-9 impacting the displayed values after rounding to 3dp (i.e. in the original, 0.08350000000000000477 rounds to 0.084 as the value is just above 0.0835; in the new version, 0.08349999785423278809 rounds to 0.083 as it just doesn't reach 0.0835)

Copy link
Contributor

@bayliffe bayliffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@bayliffe bayliffe merged commit f591127 into environment_upgrade_feature_branch Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants