Skip to content

Conversation

@maxwhitemet
Copy link
Contributor

This PR updates the acceptance test data for batch 9.

@mspelman07 mspelman07 changed the base branch from master to environment_upgrade_feature_branch July 8, 2025 12:51
@maxwhitemet maxwhitemet force-pushed the acceptance_tests_batch_9 branch from 8c0a71d to 44d87c4 Compare July 8, 2025 13:04
Copy link
Contributor

@bayliffe bayliffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maxwhitemet, there are quite a lot of value changes in this set of new acceptance test data. Have you looked at the causes of these? Can you please comment on them so we have a record.

data/regrid/bilinear_landmask_2/kgo_multi_realization.nc
DIFFER : LENGTHS : ATTRIBUTE : calendar : VARIABLE : forecast_reference_time : 9 <> 8 : VALUES : "gregorian" : "standard"
DIFFER : LENGTHS : ATTRIBUTE : calendar : VARIABLE : time : 9 <> 8 : VALUES : "gregorian" : "standard"
DIFFER : VARIABLE : air_temperature : POSITION : [0,0,51] : VALUES : 288.245 <> 288.245
DIFFER : VARIABLE : air_temperature : POSITION : [0,4,26] : VALUES : 292.045 <> 292.045
DIFFER : VARIABLE : air_temperature : POSITION : [0,4,30] : VALUES : 288.505 <> 288.505
DIFFER : VARIABLE : air_temperature : POSITION : [0,6,24] : VALUES : 290.529 <> 290.529
DIFFER : VARIABLE : air_temperature : POSITION : [0,7,24] : VALUES : 290.03 <> 290.03
=============================================
data/regrid/landmask/kgo.nc
DIFFER : LENGTHS : ATTRIBUTE : calendar : VARIABLE : forecast_reference_time : 9 <> 8 : VALUES : "gregorian" : "standard"
DIFFER : LENGTHS : ATTRIBUTE : calendar : VARIABLE : time : 9 <> 8 : VALUES : "gregorian" : "standard"
DIFFER : VARIABLE : air_temperature : POSITION : [9,27] : VALUES : 286.594 <> 286.133
DIFFER : VARIABLE : air_temperature : POSITION : [13,23] : VALUES : 286.523 <> 287.586
DIFFER : VARIABLE : air_temperature : POSITION : [18,16] : VALUES : 287.789 <> 288.266
DIFFER : VARIABLE : air_temperature : POSITION : [18,20] : VALUES : 286.18 <> 286.359
DIFFER : VARIABLE : air_temperature : POSITION : [25,27] : VALUES : 285.875 <> 287.531
=============================================
data/regrid/landmask/kgo_multi_realization.nc
DIFFER : LENGTHS : ATTRIBUTE : calendar : VARIABLE : forecast_reference_time : 9 <> 8 : VALUES : "gregorian" : "standard"
DIFFER : LENGTHS : ATTRIBUTE : calendar : VARIABLE : time : 9 <> 8 : VALUES : "gregorian" : "standard"
DIFFER : VARIABLE : air_temperature : POSITION : [0,2,32] : VALUES : 288.5 <> 288.062
DIFFER : VARIABLE : air_temperature : POSITION : [0,16,39] : VALUES : 287.812 <> 286.547
DIFFER : VARIABLE : air_temperature : POSITION : [0,18,40] : VALUES : 288.328 <> 287.75
DIFFER : VARIABLE : air_temperature : POSITION : [0,21,33] : VALUES : 284 <> 283.406
DIFFER : VARIABLE : air_temperature : POSITION : [0,21,42] : VALUES : 287.75 <> 287.578
=============================================
data/resolve-wind-components/basic/kgo.nc
DIFFER : LENGTHS : ATTRIBUTE : calendar : VARIABLE : forecast_reference_time : 9 <> 8 : VALUES : "gregorian" : "standard"
DIFFER : LENGTHS : ATTRIBUTE : calendar : VARIABLE : time : 9 <> 8 : VALUES : "gregorian" : "standard"
DIFFER : VARIABLE : grid_eastward_wind : POSITION : [0,0,0] : VALUES : 10.9129 <> 10.9129
DIFFER : VARIABLE : grid_eastward_wind : POSITION : [0,0,1] : VALUES : 10.8892 <> 10.8892
DIFFER : VARIABLE : grid_eastward_wind : POSITION : [0,0,2] : VALUES : 11.4873 <> 11.4873
DIFFER : VARIABLE : grid_eastward_wind : POSITION : [0,0,3] : VALUES : 11.5951 <> 11.5951
DIFFER : VARIABLE : grid_eastward_wind : POSITION : [0,0,4] : VALUES : 10.9695 <> 10.9695
DIFFER : VARIABLE : grid_northward_wind : POSITION : [0,0,0] : VALUES : 1.17348 <> 1.17349
DIFFER : VARIABLE : grid_northward_wind : POSITION : [0,0,1] : VALUES : 0.927028 <> 0.927002
DIFFER : VARIABLE : grid_northward_wind : POSITION : [0,0,2] : VALUES : 0.647678 <> 0.647662
DIFFER : VARIABLE : grid_northward_wind : POSITION : [0,0,3] : VALUES : 1.2202 <> 1.22019
DIFFER : VARIABLE : grid_northward_wind : POSITION : [0,0,4] : VALUES : 1.01265 <> 1.01262
=============================================
data/shower-condition-probability/kgo.nc
DIFFER : LENGTHS : ATTRIBUTE : calendar : VARIABLE : forecast_reference_time : 9 <> 8 : VALUES : "gregorian" : "standard"
DIFFER : LENGTHS : ATTRIBUTE : calendar : VARIABLE : time : 9 <> 8 : VALUES : "gregorian" : "standard"
DIFFER : VARIABLE : probability_of_shower_condition_above_threshold : POSITION : [10,29] : VALUES : 0.555556 <> 0.666667

@maxwhitemet
Copy link
Contributor Author

All files experience calendar changes.

Additionally, two files are affected purely by precision changes:

  • data/regrid/bilinear_landmask_2/kgo_multi_realization.nc (max diff: 3.05176e-05 K)
  • data/resolve-wind-components/basic/kgo.nc (max diff: 6.532669067382812e-05
    in grid_eastward_wind variable and 9.799003601074219e-05 in grid_northward_wind variable).

Regriding issues
Two regrid files experience issues when run through AdjustLandSeaPoints due to issues related to cKDTree @bayliffe documented in https://github.com/metoppv/mo-blue-team/issues/916:

  • data/regrid/landmask/kgo.nc
  • data/regrid/landmask/kgo_multi_realization.nc

Information on data/shower-condition-probability/kgo.nc to follow

@maxwhitemet
Copy link
Contributor Author

The change of values for data/shower-condition-probability/kgo.nc originates from the thresholding of the convection input.
At index [2, 10, 29] in the variable convection_thresholded, the value was originally 0.0 but is now 1.0. This is because of a precision change. Converting the thresholds to float 32 prevents this change (see associated PR for improver repository)

@bayliffe bayliffe force-pushed the acceptance_tests_batch_9 branch from 44d87c4 to 66d67d1 Compare July 15, 2025 16:19
@bayliffe bayliffe merged commit e259152 into environment_upgrade_feature_branch Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants