Skip to content

Conversation

@mspelman07
Copy link
Contributor

@mspelman07 mspelman07 commented Jul 3, 2025

TIcket: https://github.com/metoppv/mo-blue-team/issues/938
IMPROVER PR: metoppv/improver#2147

This PR adds in the acceptance test updates for batch 4. The main changes are related to conventions and calendar attribute. There is a small change to the data from estimate emos coefficients. This was identified in metoppv/improver#2127 as being caused by the minimize function in the class.

estimate-emos-coefficients/normal/default_initial_guess_kgo.nc
different attribute value /forecast_reference_time/calendar - gregorian standard

estimate-emos-coefficients/normal/kgo.nc
different attribute value /forecast_reference_time/calendar - gregorian standard
different data /emos_coefficient_alpha - Not equal to tolerance rtol=0.0001, atol=0.0001

Mismatched elements: 1 / 1 (100%)
Max absolute difference: 0.0054245
Max relative difference: 0.00012637
 x: array(42.932022, dtype=float32)
 y: array(42.926598, dtype=float32)

estimate-emos-coefficients/normal/land_only_kgo.nc
different attribute value /forecast_reference_time/calendar - gregorian standard

estimate-emos-coefficients/normal/sites/point_by_point_default_initial_guess/kgo.nc
different attribute value /forecast_reference_time/calendar - gregorian standard

estimate-emos-coefficients/normal/sites/point_by_point/realizations_kgo.nc
different attribute value /forecast_reference_time/calendar - gregorian standard

estimate-emos-coefficients/normal/sites/point_by_point/kgo.nc
different attribute value /forecast_reference_time/calendar - gregorian standard

estimate-emos-coefficients/normal/realizations/kgo.nc
different attribute value /forecast_reference_time/calendar - gregorian standard

estimate-emos-coefficients/truncated_normal/kgo.nc
different attribute value /forecast_reference_time/calendar - gregorian standard

extend-radar-mask/basic/kgo.nc
different attribute value /forecast_reference_time/calendar - gregorian standard
different attribute value /time/calendar - gregorian standard

extract/sites/kgo_spot.nc
different attribute value /forecast_reference_time/calendar - gregorian standard
different attribute value /blend_time/calendar - gregorian standard
different attribute value /time/calendar - gregorian standard

extract/change_units/kgo.nc
different attribute value /forecast_reference_time/calendar - gregorian standard
different attribute value /time/calendar - gregorian standard

extract/multiple_constraints_units/kgo.nc
different attribute value /forecast_reference_time/calendar - gregorian standard
different attribute value /time/calendar - gregorian standard

extract/grids/kgo_grid_latlon.nc
different attribute value /forecast_reference_time/calendar - gregorian standard
different attribute value /blend_time/calendar - gregorian standard
different attribute value /time/calendar - gregorian standard

extract/grids/kgo_grid_uk.nc
different attribute value /forecast_reference_time/calendar - gregorian standard
different attribute value /blend_time/calendar - gregorian standard
different attribute value /time/calendar - gregorian standard

extract/basic/kgo.nc
different attribute value /forecast_reference_time/calendar - gregorian standard
different attribute value /time/calendar - gregorian standard

extract/range_constraints/kgo.nc
different attribute value /forecast_reference_time/calendar - gregorian standard
different attribute value /time/calendar - gregorian standard

extract/multiple_constraints/kgo.nc
different attribute value /forecast_reference_time/calendar - gregorian standard
different attribute value /time/calendar - gregorian standard

extract/list_constraints/kgo.nc
different attribute value /forecast_reference_time/calendar - gregorian standard
different attribute value /time/calendar - gregorian standard

enforce-consistent-forecasts/single_bound_probability_kgo.nc
different attribute value /forecast_reference_time/calendar - gregorian standard
different attribute value /time/calendar - gregorian standard

enforce-consistent-forecasts/single_bound_percentile_kgo.nc
different attribute value /forecast_reference_time/calendar - gregorian standard
different attribute value /blend_time/calendar - gregorian standard
different attribute value /time/calendar - gregorian standard

enforce-consistent-forecasts/single_bound_realization_kgo.nc
different attribute value /forecast_reference_time/calendar - gregorian standard
different attribute value /time/calendar - gregorian standard

enforce-consistent-forecasts/double_bound_percentile_kgo.nc
different attribute value /forecast_reference_time/calendar - gregorian standard
different attribute value /blend_time/calendar - gregorian standard
different attribute value /time/calendar - gregorian standard

enforce-consistent-forecasts/single_bound_probability_time_enforce_kgo.nc
different attribute value /forecast_reference_time/calendar - gregorian standard
different attribute value /time/calendar - gregorian standard

feels_like_temp/ukvx/kgo.nc
different attribute value /forecast_reference_time/calendar - gregorian standard
different attribute value /time/calendar - gregorian standard

extract-from-table/kgo_lapse_class.nc
different attribute value /forecast_reference_time/calendar - gregorian standard
different attribute value /time/calendar - gregorian standard

extract-from-table/kgo_gust_ratio.nc
different attribute value /forecast_reference_time/calendar - gregorian standard
different attribute value /time/calendar - gregorian standard

duration-subdivision/kgo_daymask.nc
different attribute value /forecast_reference_time/calendar - gregorian standard
different attribute value /time/calendar - gregorian standard

duration-subdivision/kgo_nomask.nc
different attribute value /forecast_reference_time/calendar - gregorian standard
different attribute value /time/calendar - gregorian standard

duration-subdivision/kgo_nightmask.nc
different attribute value /forecast_reference_time/calendar - gregorian standard
different attribute value /time/calendar - gregorian standard

There is a small IMPROVER PR to accompany these changes to enforce the data type of the outputs.

@maxwhitemet
Copy link
Contributor

Looks good to me 👍

@bayliffe bayliffe merged commit 1163432 into environment_upgrade_feature_branch Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants