Skip to content

Conversation

@bayliffe
Copy link
Contributor

Recent changes to the cloud condensation level code and acceptance test data were started and completed whilst the environment upgrade was underway. As a result they were not capture in the upgrade process.

The KGO are variously modified, e.g.

data/cloud-condensation-level/without_id_attr/kgo.nc
DIFFER : LENGTHS : ATTRIBUTE : calendar : VARIABLE : forecast_reference_time : 9 <> 8 : VALUES : "gregorian" : "standard"
DIFFER : LENGTHS : ATTRIBUTE : calendar : VARIABLE : time : 9 <> 8 : VALUES : "gregorian" : "standard"
DIFFER : VARIABLE : air_temperature_at_condensation_level : POSITION : [0,36,36] : VALUES : 291.016 <> 291.008
DIFFER : VARIABLE : air_temperature_at_condensation_level : POSITION : [0,39,38] : VALUES : 293.609 <> 293.602
DIFFER : VARIABLE : air_temperature_at_condensation_level : POSITION : [1,18,35] : VALUES : 276.742 <> 276.734
DIFFER : VARIABLE : air_temperature_at_condensation_level : POSITION : [1,52,3] : VALUES : 277.156 <> 277.148
DIFFER : VARIABLE : air_temperature_at_condensation_level : POSITION : [2,0,44] : VALUES : 293.109 <> 293.102
DIFFER : VARIABLE : air_pressure_at_condensation_level : POSITION : [0,25,29] : VALUES : 53578.8 <> 53578.8
DIFFER : VARIABLE : air_pressure_at_condensation_level : POSITION : [0,43,28] : VALUES : 72629.3 <> 72629.3
DIFFER : VARIABLE : air_pressure_at_condensation_level : POSITION : [0,44,0] : VALUES : 101927 <> 101927
DIFFER : VARIABLE : air_pressure_at_condensation_level : POSITION : [0,45,9] : VALUES : 98499.1 <> 98499.1
DIFFER : VARIABLE : air_pressure_at_condensation_level : POSITION : [0,46,0] : VALUES : 101657 <> 101657

data/cloud-condensation-level/with_id_attr/kgo.nc
DIFFER : LENGTHS : ATTRIBUTE : calendar : VARIABLE : forecast_reference_time : 9 <> 8 : VALUES : "gregorian" : "standard"
DIFFER : LENGTHS : ATTRIBUTE : calendar : VARIABLE : time : 9 <> 8 : VALUES : "gregorian" : "standard"
DIFFER : VARIABLE : air_temperature_at_condensation_level : POSITION : [0,36,36] : VALUES : 291.016 <> 291.008
DIFFER : VARIABLE : air_temperature_at_condensation_level : POSITION : [0,39,38] : VALUES : 293.609 <> 293.602
DIFFER : VARIABLE : air_temperature_at_condensation_level : POSITION : [1,18,35] : VALUES : 276.742 <> 276.734
DIFFER : VARIABLE : air_temperature_at_condensation_level : POSITION : [1,52,3] : VALUES : 277.156 <> 277.148
DIFFER : VARIABLE : air_temperature_at_condensation_level : POSITION : [2,0,44] : VALUES : 293.109 <> 293.102
DIFFER : VARIABLE : air_pressure_at_condensation_level : POSITION : [0,25,29] : VALUES : 53578.8 <> 53578.8
DIFFER : VARIABLE : air_pressure_at_condensation_level : POSITION : [0,43,28] : VALUES : 72629.3 <> 72629.3
DIFFER : VARIABLE : air_pressure_at_condensation_level : POSITION : [0,44,0] : VALUES : 101927 <> 101927
DIFFER : VARIABLE : air_pressure_at_condensation_level : POSITION : [0,45,9] : VALUES : 98499.1 <> 98499.1
DIFFER : VARIABLE : air_pressure_at_condensation_level : POSITION : [0,46,0] : VALUES : 101657 <> 101657

The changes are generally small, but larger than precision. The plots below show the changes:

Temperature

image

Pressure

image

The newton iterator within the plugin is returning answers that differ at a couple of decimal places. This can also in turn result in the masking within the plugin being different as the value comparison shakes out slightly differently.

mask = ccl_pressure > self.pressure.data

Old environment mask 1 point:
ccl_pressure [89759.96]
pressure [89677.25]

New environment masks 7 points:
ccl_pressure [102487.88 102200.26  89759.96 102076.51 102490.13 102371.01 101566.38]
pressure [102487.875 102200.25   89677.25  102076.5   102490.125 102371. 101566.375]

@bayliffe bayliffe changed the base branch from master to environment_upgrade_feature_branch July 28, 2025 13:23
@bayliffe bayliffe requested a review from maxwhitemet July 29, 2025 08:25
Copy link
Contributor

@maxwhitemet maxwhitemet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look okay to me.

@maxwhitemet maxwhitemet merged commit 26e652e into environment_upgrade_feature_branch Jul 29, 2025
@bayliffe bayliffe deleted the cloud_condensation_env_upgrade branch July 29, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants