Skip to content

Environment upgrade: expected value #2139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maxwhitemet merged 2 commits into from
Jun 27, 2025
Merged

Environment upgrade: expected value #2139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
926e639
Modify expected scalar values in unit tests to have specific float32 …
bayliffe Jun 25, 2025
f2a7d15
Update checksums
bayliffe Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion improver_tests/acceptance/SHA256SUMS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,7 @@ d2cab1d3d8aa588be08a3d7d65e95e859fed37daa767e8d4a2bdaae25702b9a8 ./estimate-emo
1032b6e41987c08ad4caace25e182a02701177408461c7b573f3e8b304b31c16 ./estimate-emos-coefficients/truncated_normal/truth/20170603T1500Z-PT0000H-horizontal_wind_speed_at_10m.nc
fe84db49d69ea62e2e82312c7b3d860c7329c627d79d76c2543d365f69d2e0d8 ./estimate-emos-coefficients/truncated_normal/truth/20170604T1500Z-PT0000H-horizontal_wind_speed_at_10m.nc
386284bf4c5daa3567fb78ca00331494c99ac664902490188dfdf98c39a494ba ./expected-value/deterministic.nc
c4adfd73537c8bc7b5e3d70ed3161eff0ecc8f155fe4b08b97b9fa8c3cfa9171 ./expected-value/kgo.nc
64bcba24bc314d1ffc6bb7adbae6b9e6d872cb75e8ef834463e4fb72e55ad16a ./expected-value/kgo.nc
f61aa0326219c7e3934823bc4d607c2b3ec022a7c1df15d3519aea91207effce ./expected-value/percentile.nc
00167c391d157276adbb4e4b483237f9d8d0680aeaf5f7bfdd447b26b4f68daa ./expected-value/realization.nc
5ac47a686f2a97e73c6322a0f89c0df83e29ed8de6a2272c5283f0542a94622f ./expected-value/threshold.nc
Expand Down
4 changes: 2 additions & 2 deletions improver_tests/expected_value/test_expected_value.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,13 +129,13 @@ def test_process_threshold_basic(threshold_cube):
expval = ExpectedValue().process(threshold_cube)
# threshold probablities are asymmetric, so the mean is slightly above the
# 282 kelvin threshold
assert_allclose(expval.data, 282.15, atol=1e-6, rtol=0.0)
assert_allclose(expval.data, np.float32(282.15), atol=1e-6, rtol=0.0)


def test_process_threshold_unequal(unequal_threshold_cube):
"""Check calculation of expected value using unevenly spaced threshold data."""
expval = ExpectedValue().process(unequal_threshold_cube)
assert_allclose(expval.data, 282.0925, atol=1e-6, rtol=0.0)
assert_allclose(expval.data, np.float32(282.0925), atol=1e-6, rtol=0.0)


def test_process_threshold_doublebounded(double_bounded_threshold_cube):
Expand Down
Loading