nimrod monkey patch #1160
Merged
nimrod monkey patch #1160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomekTrzeciak
requested review from
LaurenceBeard,
MoseleyS,
cgsandford and
tjtg
and removed request for
tjtg
…he acceptance tests do not falsely trigger the FIXME message.
…ered if the iris_nimrod_patch is available.
Contributor
|
Issues
======
- Added 1
Complexity increasing per file
==============================
- improver/utilities/load.py 6
See the complete overview on Codacy |
MoseleyS
approved these changes
Feb 18, 2020
LaurenceBeard
approved these changes
Feb 18, 2020
Contributor
LaurenceBeard
left a comment
LaurenceBeard
left a comment
There was a problem hiding this comment.
nice contextmanaged monkeypatching :)
Contributor
Author
I was still working on this... |
Contributor
Author
We need some way of blocking PRs from merge while being worked on. It's not the first time this happens to me. |
MoseleyS
added a commit
to MoseleyS/improver
that referenced
this pull request
Aug 22, 2024
* nimrod monkey patch * Makes monkey-patch a temporary addition so that repeated calls from the acceptance tests do not falsely trigger the FIXME message. * Adds unit-tests for Nimrod-format Radarnet data. These are only triggered if the iris_nimrod_patch is available. * Fixes problems with the monkey-patch context manager. * Pycodestyle fix Co-authored-by: Stephen Moseley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable reading nimrod radar files with iris while waiting for SciTools/iris#3647 to make it through the pipeline.
Testing: