-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pydantic ColocatedData #1134
Pydantic ColocatedData #1134
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main-dev #1134 +/- ##
============================================
+ Coverage 78.53% 78.61% +0.07%
============================================
Files 120 125 +5
Lines 19939 19953 +14
============================================
+ Hits 15660 15686 +26
+ Misses 4279 4267 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
567095e
to
3a229d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🤖 🚀
Change Summary
The
ColocatedData
class is now a derived class of pydantic'sBaseModel
. Doing so ensures data validation and defines an interface, part of which we will need to guarantee successful reading in colocated data objects created outside of pyaerocom, for example, in CAMS2_82.Related issue number
Part of #857. Related work in #1120 deriving
ColocationSetup
fromBaseModel
Checklist