Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pydantic for Aeroval setupclasses.py #1017
Pydantic for Aeroval setupclasses.py #1017
Changes from 1 commit
5597317
d5245d7
9a838b3
eb0c309
8c18795
b1e7e7f
ad50d4d
0d0cda1
aae4521
52659d5
594836d
5923437
339d450
5d947ab
509625b
ea9e08d
3f99eb2
55b5319
5bc2024
1b304e1
6bab371
5acb6b9
781d7fc
03c0d7f
a93f0ff
ce7e410
095b3bd
bd3bfb8
aa8df1f
044a55d
44fae29
a27e6d0
d2cdeed
088f728
abb0009
d7a8ff1
cefc461
27b6196
c62ea2b
2d8e94a
19dd2e1
a453d5b
dece69f
abe39cc
c258182
cd93e96
58d7a6c
a371b0c
9394bfb
e9971f0
e25539f
f3956d9
ed92208
f28a5c9
d9299e3
67ee0f5
b6e531f
00e8c67
49aeea5
db0f1f5
220b2e1
3d1e1c4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 8 in pyaerocom/aeroval/setupclasses.py
Codecov / codecov/patch
pyaerocom/aeroval/setupclasses.py#L8
Check warning on line 183 in pyaerocom/aeroval/setupclasses.py
Codecov / codecov/patch
pyaerocom/aeroval/setupclasses.py#L183
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is
time_cfg_keys
really needed?How is this different than:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is cleaner. Changed.
Check warning on line 346 in pyaerocom/aeroval/setupclasses.py
Codecov / codecov/patch
pyaerocom/aeroval/setupclasses.py#L346
Check warning on line 355 in pyaerocom/aeroval/setupclasses.py
Codecov / codecov/patch
pyaerocom/aeroval/setupclasses.py#L354-L355
Check warning on line 379 in pyaerocom/aeroval/setupclasses.py
Codecov / codecov/patch
pyaerocom/aeroval/setupclasses.py#L379
Check warning on line 390 in pyaerocom/aeroval/setupclasses.py
Codecov / codecov/patch
pyaerocom/aeroval/setupclasses.py#L390
Check warning on line 428 in pyaerocom/aeroval/setupclasses.py
Codecov / codecov/patch
pyaerocom/aeroval/setupclasses.py#L428
Check warning on line 440 in pyaerocom/aeroval/setupclasses.py
Codecov / codecov/patch
pyaerocom/aeroval/setupclasses.py#L440