fix(useTrackerSuspense): fix performance issues when multiple useTracker with suspense exist and rebuild test cases. Closes #454 #455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Nice! I was going to tackle this today and your solution seems very elegant! this closes #454 |
Grubba27
reviewed
Oct 16, 2025
Grubba27
reviewed
Oct 16, 2025
Grubba27
reviewed
Oct 16, 2025
Grubba27
reviewed
Oct 16, 2025
Grubba27
reviewed
Oct 16, 2025
Grubba27
approved these changes
Oct 16, 2025
Contributor
Grubba27
left a comment
Grubba27
left a comment
There was a problem hiding this comment.
Looks good! I'll release a beta with these changes and we can test around
…ker with suspense exist and rebuild test cases. Closes meteor#454
Contributor
|
Published this under [email protected] please give a test and let me know! |
Contributor
Author
@Grubba27 during testing of version 4.0.1-beta.0, I identified an issue with the withDeps implementation and have submitted a new PR (#457) to address it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR primarily addresses the performance issue described in #454.
Problem Analysis
In the original implementation, the cache was immediately cleared every time a Promise was thrown and resolved. This caused components to re-throw Promises upon updates, leading to an exponential growth in Promise throwing when multiple
useTrackerhooks were used concurrently.Solution
The key insight is that immediate cache clearance is only necessary on the Server-Side. This optimization significantly reduces unnecessary Promise re-throws and improves performance in components with multiple
useTrackerinstances.Additional Changes
useTrackerwith Suspense functionality