-
Notifications
You must be signed in to change notification settings - Fork 168
Adds a method to ReactMeteorDataComponent for retrieving the wrapped … #245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@rooch84: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
| getMeteorData() { | ||
| return getMeteorData(this.props); | ||
| } | ||
| getWrappedComponent() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind fixing the spacing here to align with the style used in the rest of the file?
|
This would be fixed by #266 I guess. |
|
Chris Rooney seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
1 similar comment
|
Chris Rooney seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
On version 2.0.0 a lot of things were changed then if you think this PR is still valid please update it and open again. Thanks. |
|
Has this been implemented? |
|
@derwaldgeist in the current release, withTracker() uses React.forwardRef, so you should be able to get the wrapped component symply by using a regular React ref |
|
@yched Thanks for your feedback. Yeah, I realized this in the meantime. I was still using version 1.0.0 of this package so far, where it did not work. Had to update Meteor to 1.10 though, because of version dependencies on the ecmascript package. |
…component.
This is useful if the parent component needs to call a method on the child.