Skip to content

Conversation

@rooch84
Copy link

@rooch84 rooch84 commented Jan 15, 2018

…component.

This is useful if the parent component needs to call a method on the child.

@apollo-cla
Copy link

@rooch84: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

getMeteorData() {
return getMeteorData(this.props);
}
getWrappedComponent() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind fixing the spacing here to align with the style used in the rest of the file?

@yched
Copy link
Contributor

yched commented Apr 2, 2019

This would be fixed by #266 I guess.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Chris Rooney seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Chris Rooney seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@filipenevola
Copy link
Contributor

On version 2.0.0 a lot of things were changed then if you think this PR is still valid please update it and open again. Thanks.

@derwaldgeist
Copy link

Has this been implemented?

@yched
Copy link
Contributor

yched commented May 14, 2020

@derwaldgeist in the current release, withTracker() uses React.forwardRef, so you should be able to get the wrapped component symply by using a regular React ref

@derwaldgeist
Copy link

@yched Thanks for your feedback. Yeah, I realized this in the meantime. I was still using version 1.0.0 of this package so far, where it did not work. Had to update Meteor to 1.10 though, because of version dependencies on the ecmascript package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants