fix: update error definitions (nodejs#2112)

metcoder95 · Jul 21, 2023 · 4e6e54e · 4e6e54e
1 parent 095e32a
commit 4e6e54e
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/test/types/errors.test-d.ts b/test/types/errors.test-d.ts
@@ -1,8 +1,11 @@
 import { expectAssignable } from 'tsd'
 import { errors } from '../..'
 import Client from '../../types/client'
+import { IncomingHttpHeaders } from "../../types/header";
 
 expectAssignable<errors.UndiciError>(new errors.UndiciError())
+expectAssignable<string>(new errors.UndiciError().name)
+expectAssignable<string>(new errors.UndiciError().code)
 
 expectAssignable<errors.UndiciError>(new errors.ConnectTimeoutError())
 expectAssignable<errors.ConnectTimeoutError>(new errors.ConnectTimeoutError())
@@ -28,6 +31,10 @@ expectAssignable<errors.UndiciError>(new errors.ResponseStatusCodeError())
 expectAssignable<errors.ResponseStatusCodeError>(new errors.ResponseStatusCodeError())
 expectAssignable<'ResponseStatusCodeError'>(new errors.ResponseStatusCodeError().name)
 expectAssignable<'UND_ERR_RESPONSE_STATUS_CODE'>(new errors.ResponseStatusCodeError().code)
+expectAssignable<number>(new errors.ResponseStatusCodeError().status)
+expectAssignable<number>(new errors.ResponseStatusCodeError().statusCode)
+expectAssignable<IncomingHttpHeaders | string[] | null>(new errors.ResponseStatusCodeError().headers)
+expectAssignable<null | Record<string, any> | string>(new errors.ResponseStatusCodeError().body)
 
 expectAssignable<errors.UndiciError>(new errors.InvalidArgumentError())
 expectAssignable<errors.InvalidArgumentError>(new errors.InvalidArgumentError())

diff --git a/types/errors.d.ts b/types/errors.d.ts
@@ -4,7 +4,10 @@ import Client from './client'
 export default Errors
 
 declare namespace Errors {
-  export class UndiciError extends Error { }
+  export class UndiciError extends Error {
+    name: string;
+    code: string;
+  }
 
   /** Connect timeout error. */
   export class ConnectTimeoutError extends UndiciError {
@@ -31,6 +34,12 @@ declare namespace Errors {
   }
 
   export class ResponseStatusCodeError extends UndiciError {
+    constructor (
+      message?: string,
+      statusCode?: number,
+      headers?: IncomingHttpHeaders | string[] | null,
+      body?: null | Record<string, any> | string
+    );
     name: 'ResponseStatusCodeError';
     code: 'UND_ERR_RESPONSE_STATUS_CODE';
     body: null | Record<string, any> | string