Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add candy machine gpa builders #95

Merged
merged 13 commits into from
May 9, 2022
Merged

feat: add candy machine gpa builders #95

merged 13 commits into from
May 9, 2022

Conversation

thlorenz
Copy link
Contributor

@thlorenz thlorenz commented May 8, 2022

Summary

  • add GPA builders to find Candy Machines by wallet and authority
  • indluded operation handlers exposed via CandyMachine Client

thlorenz added 13 commits May 5, 2022 10:54
@thlorenz
chore: export config types
d060555
@thlorenz
chore: replace instanceof with is as that works across web3.js ve…
ad216bb 
…rsions
@thlorenz
chore: remove 'try' prefix from conversion methods
5d4cf41
@thlorenz
chore: spread candy machine data fields
273e339
@thlorenz
chore: UnreachableCase Error is now an SDK Error
c2b8f28
@thlorenz
chore: findCandyMachine now uses metaplex rpc
dace887 
- added proper error handling if created candy machine not found
@thlorenz
chore: unreachable case error includes value in message
ee1b364
@thlorenz
chore: expose candy machine client as candyMachines
2a7f066
@thlorenz
feat: candyMachine GPA including tests
db19409
@thlorenz
chore: gpa operation handlers and using those in test
db661f6
@thlorenz
chore: upgrade to candyMachines renaming
93e6a10
@thlorenz
Merge branch 'main' into thlorenz/feat/cm-gpa-builder
8de5bff 
* main:
  chore: small candy machine changes as requested (#94)
@thlorenz
chore: Given, When, Then in tests to make Loris happy
ecf5f6f
lorisleiva
lorisleiva approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor

@lorisleiva lorisleiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it! Thank you. ❤️

src/programs/candyMachine/gpaBuilders/CandyMachineGpaBuilder.ts
}

// wallet same as solTreasury
candyMachineAccountsForWallet(wallet: PublicKey) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remind me to have a chat with you about this. I have recently been creating GpaBuilder classes for each account type (that extend a program GpaBuild when needed) where the constructor enforces the account constraint. I think this is good for now but something to discuss when we think about auto-generating them.

@thlorenz thlorenz merged commit 5e1ea1d into main May 9, 2022
@thlorenz thlorenz deleted the thlorenz/feat/cm-gpa-builder branch May 9, 2022 16:53
thlorenz added a commit that referenced this pull request May 9, 2022
@thlorenz
Merge branch 'main' into thlorenz/feat/manage-candy-machine
217f9fd 
* main:
  feat: add candy machine gpa builders (#95)
  v0.8.0
  Use Rollup and Babel to create builds (#93)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorisleiva lorisleiva lorisleiva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thlorenz @lorisleiva