more efficient base image#131
Conversation
|
Hey, @bwoodhouse322 and thanks for this! Have you actually tested this with a few types of apps? I assume that, at least for web applications, |
|
Hey @radu-matei This isn't tested, but you are absolutely right the ca-certs must and have been added. Could you quickly test? I don't have Minikube set up on my current machine, but will test tomorrow if not possible, Thanks! |
|
https://github.com/iron-io/dockers/tree/master/go the iron/go image is production ready I believe i.e niggles like ca-certs have been addressed already. Maybe this may make a more suitable base image |
|
OK silly me I can tests this just with docker, can I use the app that you used in your screenshot? just to compare the change? |
|
Sure, go ahead and use it! |
|
is it on your Github? I can only see the Docker image name, not the app name 😜 |
|
Yeah, it is actually in this repo - https://github.com/metaparticle-io/package/blob/master/go/examples/web-aci/main.go |
|
Updated and tested with the example above, comes out at 6mb! https://hub.docker.com/r/bwoodhouse322/go-test/tags/ Thanks @radu-matei ! |
|
@brendandburns Are you still active on this project? Just wanted to make you aware of this PR if interested, thanks! |
|
Sorry for the delay, vacations etc. definitely still active. This LGTM. |
* Updated Java package tutorial instructions (metaparticle-io#110) * Correct the expected value of the @Package/repository value * Mention the need for the @Package/publish=true field * Removed use of the @Runtime/publicAddress field since the tutorial does not appear to be ACI specific * Correct the type of service created on the remote Kubernetes cluster * Added missing unit test dependencies (metaparticle-io#109) * Update README.md (metaparticle-io#106) Slight typo. "a nd language of choice" ===> "and language of choice" * Create dotnet testrunner (metaparticle-io#87) * fix up examples and documentation * fix up indenting * add initial code for a dotnet test runner as part of metaparticle * add missed file * renamed env vars to be conssitent and also moved braces to new lines * Add travis for dotnet (#3) * add initial travis file * fix up missing dash * try again going into the right directory this time * no need for mono and we can set the dotnet core version * make build.sh executable * see what directory we are on * set to unix type * build the examples * move tests to attributes rather than using env var * Initial Set of Unit Tests For DotNet Metaparticle.Package (metaparticle-io#111) * Create unit test project and added tests for Metaparticle.Package.Config * Added unit tests for Config and an initial set of tests for the Driver * Minor update to Java sharding tutorial instructions (metaparticle-io#112) (metaparticle-io#113) * Fix typo in tutorial (metaparticle-io#114) * Support containerizing of Spring Boot apps (metaparticle-io#115) * Necessary to upgrade PowerMock version in order to run tests * Additions to gitignore file * Support sharding. (metaparticle-io#118) * Update definition of local functions with explicit const (metaparticle-io#120) * Add some words on Spring Boot support to package Java tutorial (metaparticle-io#121) * Follow up to previous PR for issue metaparticle-io#6 * Lazy intialize the Docker client. (metaparticle-io#119) * Fix missing comma, go fmt (metaparticle-io#122) * Adding rust (metaparticle-io#86) * learned a touch of rust * no decorator * base rust entrypoint * with bare docker builder and executor (#3) * Real traits jim (#4) * add placeholder functions for actual interface * move builder trait into builder module * move docker builder struct into correct module * move existing functions onto trait implementation * move executor trait to appropriate module * move executor struct into correct module * initial builder working * added docker run support; cleaned up command execs * refactor to str refs; added readme * We need strings here, I think The result of the format! call is a string, (as is the result of other ways of getting a u64 into a string). This change makes the method compile without changing anything's type signature. There might be other was to accomplish this, but I haven't found one. * added web example * use executable's path as Docker context * wrapped docker cmds in sh * write dockerfile to docker context explicitly * fix copy paste error in README * Python fix + cleanup (metaparticle-io#123) * general cleanup * nested options should be processed into objects from dictionaries * comments on logging; pythonic json read * Drive-by cleanups (metaparticle-io#126) * Let requirements match the latest version * Make print statements Python3-compatible * insulate more against Py2 -> Py3 changes * Add python additionalFiles option (metaparticle-io#125) * add python additionalFiles option * in case a dir is given * added tests for additionalFiles * Lazy intialize the Docker client. (metaparticle-io#127) * more efficient base image (metaparticle-io#131) * more efficient base image * squashed layers * removed breaking character * adding certs * sized down to 6mb and tested with simple http server
3 participants
No description provided.