Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammatical properties in presentation xml #554

Closed
Intelligent2013 opened this issue Nov 18, 2021 · 9 comments
Closed

Grammatical properties in presentation xml #554

Intelligent2013 opened this issue Nov 18, 2021 · 9 comments
Assignees
Labels

Comments

@Intelligent2013
Copy link
Contributor

Source: #550

The document: https://github.com/metanorma/iso-19135/tree/master/sources/iso-19135-1-2021

03-terms.adoc:

==== register

[%metadata]
grammar::
isNoun::: true

set of files containing {{identifier,identifiers}} assigned to items with
descriptions of the associated items

The presentation xml contains n at the end of preferred:

<term id="term-register">
	<name>3.1.10</name>
	<preferred>register n</preferred>
	<definition>

Should I process n as indication for noun or is it a bug?

Semantic xml is ok:

<term id="term-register">
	<preferred>
		<expression>
			<name>register</name>
			<grammar>
				<isNoun>true</isNoun>
			</grammar>
		</expression>
	</preferred>
	<definition>
@ronaldtse
Copy link
Contributor

Bug indeed. Thanks for investigating.

@ronaldtse ronaldtse moved this from Triage to Urgent in Metanorma Nov 19, 2021
@Intelligent2013
Copy link
Contributor Author

Additional issues:

  • terms in languages 'eng' and 'fra':
    adoc:
=== jetty

[%metadata]
language:: eng

preferred:[pier]

[%metadata]
language:: fra

deck structure supported by vertical and possibly inclined piles extending into the sea, frequently in a
direction normal to the coastline

Presentation xml contains only 'eng' (due two terms in the one element?):

<term id="term-jetty">
	<name>4.9</name>
	<preferred language="eng">jetty; pier</preferred>
	<definition>
		<p id="_">deck structure supported by vertical and possibly inclined piles extending into the sea, frequently in a
direction normal to the coastline</p>
	</definition>
</term>
  • pronunciation
=== disturbance

[%metadata]
pronunciation:: dıˈstɜ:bəns

any event or series of events that disrupt ecosystem, community, or population structure and alters the
physical environment

no info for pronunciation in the metanorma xml:

<term id="term-disturbance">
	<name>4.10</name>
	<preferred>disturbance</preferred>
	<definition>
		<p id="_">any event or series of events that disrupt ecosystem, community, or population structure and alters the
physical environment</p>
	</definition>
</term>

@opoudjis
Copy link
Contributor

Should I process n as indication for noun or is it a bug?

Let's not call it a bug, let's call it a different convention to what ISO 10241-1 A.1.3.2.4 recommends. Fixing.

@opoudjis
Copy link
Contributor

opoudjis commented Nov 27, 2021

Oversight in model: we will also need to add sg/pl to model. (And dual: we need grammatical number as a category.)

@opoudjis
Copy link
Contributor

There is another issue: the grammatical information in presentation XML needs to be not boldfaced. @Intelligent2013 I will explicitly introduce boldfaced rendering of terms, so that it excludes grammatical information; you will likewise need to ensure that preferred, admitted, deprecated are not by default boldface.

@opoudjis
Copy link
Contributor

And grammatical information is delimited from designation by comma.

opoudjis added a commit to glossarist/concept-model that referenced this issue Nov 27, 2021
opoudjis added a commit to metanorma/metanorma-model-iso that referenced this issue Nov 27, 2021
opoudjis added a commit to metanorma/metanorma.org that referenced this issue Nov 27, 2021
opoudjis added a commit to metanorma/metanorma-standoc that referenced this issue Nov 27, 2021
opoudjis added a commit to metanorma/isodoc that referenced this issue Nov 27, 2021
opoudjis added a commit to metanorma/metanorma-standoc that referenced this issue Nov 27, 2021
opoudjis added a commit to metanorma/metanorma-generic that referenced this issue Nov 27, 2021
opoudjis added a commit to metanorma/metanorma-bipm that referenced this issue Nov 27, 2021
opoudjis added a commit to metanorma/metanorma-csa that referenced this issue Nov 27, 2021
opoudjis added a commit to metanorma/metanorma-cc that referenced this issue Nov 27, 2021
opoudjis added a commit to metanorma/metanorma-iec that referenced this issue Nov 27, 2021
opoudjis added a commit to metanorma/metanorma-iho that referenced this issue Nov 27, 2021
opoudjis added a commit to metanorma/metanorma-itu that referenced this issue Nov 27, 2021
opoudjis added a commit to metanorma/metanorma-m3aawg that referenced this issue Nov 27, 2021
opoudjis added a commit to metanorma/metanorma-mpfa that referenced this issue Nov 27, 2021
opoudjis added a commit to metanorma/metanorma-ogc that referenced this issue Nov 27, 2021
opoudjis added a commit to metanorma/metanorma-ribose that referenced this issue Nov 27, 2021
@opoudjis
Copy link
Contributor

Presentation xml contains only 'eng' (due two terms in the one element?):

The Presentation XML is conflating preferred terms for rendering; it must not if they are in different languages.

@opoudjis
Copy link
Contributor

Adding language, script, country code, pronunciation to designation rendering in Presentation XML.

@opoudjis
Copy link
Contributor

And only merging preferred terms if they don't have grammar information, have identical geographic info or language, and don't have pronunciations.

opoudjis added a commit to metanorma/isodoc that referenced this issue Nov 27, 2021
Repository owner moved this from Urgent to Done in Metanorma Nov 27, 2021
ronaldtse pushed a commit to metanorma/metanorma.org that referenced this issue Nov 29, 2021
@ronaldtse ronaldtse removed this from Metanorma Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants