Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LastScrapeTimedOut type #24

Merged
merged 1 commit into from
Oct 5, 2020
Merged

Conversation

LiJinyao
Copy link
Contributor

I get a warning says

2020/06/27 22:16:12 failed to get torrents: json: cannot unmarshal bool into Go struct field TrackerStat.arguments.torrents.trackerStats.lastScrapeTimedOut of type int

After reading the transmission rpc-spec.txt, I found that the type of LastScrapeTimedOut is boolean. So I changed the type and it works good with no warning on the latest transmission.

@vosdev
Copy link

vosdev commented Aug 10, 2020

This fixes #26 , would like to see this merged :-)

@lededje
Copy link

lededje commented Sep 13, 2020

If you want to use this before it gets merged as I do, I created a Docker file that pulls the changes from @LiJinyao:

FROM golang:1.14

RUN go get github.com/LiJinyao/transmission-exporter

WORKDIR /go/src/github.com/LiJinyao/transmission-exporter

RUN make

RUN make build

FROM alpine:latest

RUN apk add --update ca-certificates

COPY --from=0 /go/src/github.com/LiJinyao/transmission-exporter/transmission-exporter /usr/bin/transmission-exporter

RUN chmod +x /usr/bin/transmission-exporter

EXPOSE 19091

ENTRYPOINT ["/usr/bin/transmission-exporter"]

Please Note This docker file doesn't target a specific hash, but instead the head of this pr branch. If LiJinyao pushes anything else you will build that too. I don't have enough experience with Go to make Go Mods work correctly.

Copy link
Owner

@metalmatze metalmatze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@metalmatze metalmatze merged commit c032156 into metalmatze:master Oct 5, 2020
@vosdev
Copy link

vosdev commented Oct 6, 2020

Awesome!
@metalmatze Can we get a new release? :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants