duplicate metrics collected on trackers

[notslang]

I get this error:

An error has occurred during metrics collection:

96 error(s) occurred:
* collected metric transmission_torrent_downloads_total label:<name:"id" value:"155" > label:<name:"name" value:"dns-registration-2011-to-2016.csv.xz" > label:<name:"tracker" value:"udp://open.demonii.com:1337" > gauge:<value:-1 >  was collected before with the same name and label values
* collected metric transmission_torrent_leechers label:<name:"id" value:"155" > label:<name:"name" value:"dns-registration-2011-to-2016.csv.xz" > label:<name:"tracker" value:"udp://open.demonii.com:1337" > gauge:<value:-1 >  was collected before with the same name and label values
* collected metric transmission_torrent_seeders label:<name:"id" value:"155" > label:<name:"name" value:"dns-registration-2011-to-2016.csv.xz" > label:<name:"tracker" value:"udp://open.demonii.com:1337" > gauge:<value:-1 >  was collected before with the same name and label values
...

Which seems to be caused by duplicate trackers on torrents. If I do a request on the RPC then it shows that there actually are duplicate trackers on the torrent and transmission doesn't deduplicate or ignore them.

[metalmatze]

Hmm. I guess we should include a label with the tracker then. Would you like to create a PR? ☺️

[pedrojimenez]

Same problem here ...
@metalmatze have you tested this commit ? are you merging it ?

Regards

[jonnrb]

FWIW I tested this with a torrent that caused this issue it no longer crashed...

[metalmatze]

Sorry. Looking into it.

I have the feeling that it still needs an additional label. Is there a torrent, e.g. some linux distro, which has multiple trackers, so I can test this somehow?
Thanks!

[jonnrb]

https://haveibeenpwned.com/Passwords
Specifically: https://downloads.pwnedpasswords.com/passwords/pwned-passwords-2.0.txt.7z.torrent

[pedrojimenez]

Currently on master with this torrent:

* collected metric transmission_torrent_downloads_total label:<name:"id" value:"13" > label:<name:"name" value:"pwned-passwords-2.0.txt.7z" > label:<name:"tracker" value:"udp://tracker.opentrackr.org:1337" > gauge:<value:-1 >  was collected before with the same name and label values
* collected metric transmission_torrent_leechers label:<name:"id" value:"13" > label:<name:"name" value:"pwned-passwords-2.0.txt.7z" > label:<name:"tracker" value:"udp://tracker.opentrackr.org:1337" > gauge:<value:2 >  was collected before with the same name and label values
* collected metric transmission_torrent_seeders label:<name:"id" value:"13" > label:<name:"name" value:"pwned-passwords-2.0.txt.7z" > label:<name:"tracker" value:"udp://tracker.opentrackr.org:1337" > gauge:<value:305 >  was collected before with the same name and label values
* collected metric transmission_torrent_downloads_total label:<name:"id" value:"13" > label:<name:"name" value:"pwned-passwords-2.0.txt.7z" > label:<name:"tracker" value:"udp://tracker.opentrackr.org:1337" > gauge:<value:-1 >  was collected before with the same name and label values
* collected metric transmission_torrent_leechers label:<name:"id" value:"13" > label:<name:"name" value:"pwned-passwords-2.0.txt.7z" > label:<name:"tracker" value:"udp://tracker.opentrackr.org:1337" > gauge:<value:2 >  was collected before with the same name and label values
* collected metric transmission_torrent_seeders label:<name:"id" value:"13" > label:<name:"name" value:"pwned-passwords-2.0.txt.7z" > label:<name:"tracker" value:"udp://tracker.opentrackr.org:1337" > gauge:<value:305 >  was collected before with the same name and label values
* collected metric transmission_torrent_downloads_total label:<name:"id" value:"13" > label:<name:"name" value:"pwned-passwords-2.0.txt.7z" > label:<name:"tracker" value:"udp://9.rarbg.com:2750" > gauge:<value:-1 >  was collected before with the same name and label values
* collected metric transmission_torrent_leechers label:<name:"id" value:"13" > label:<name:"name" value:"pwned-passwords-2.0.txt.7z" > label:<name:"tracker" value:"udp://9.rarbg.com:2750" > gauge:<value:2 >  was collected before with the same name and label values
* collected metric transmission_torrent_seeders label:<name:"id" value:"13" > label:<name:"name" value:"pwned-passwords-2.0.txt.7z" > label:<name:"tracker" value:"udp://9.rarbg.com:2750" > gauge:<value:221 >  was collected before with the same name and label values

[pedrojimenez]

Any news on this ?

[metalmatze]

Not really from my side. I guess I'd need to take another look.

[metalmatze]

I have merged the PR and will do some more testing in the next days.

[pedrojimenez]

Thanks @metalmatze ...
I have just tested it with same source transmission and updated exporter from master ... Same results:

* collected metric transmission_torrent_leechers label:<name:"id" value:"13" > label:<name:"name" value:"pwned-passwords-2.0.txt.7z" > label:<name:"tracker" value:"udp://9.rarbg.com:2750" > gauge:<value:0 >  was collected before with the same name and label values

* collected metric transmission_torrent_seeders label:<name:"id" value:"13" > label:<name:"name" value:"pwned-passwords-2.0.txt.7z" > label:<name:"tracker" value:"udp://9.rarbg.com:2750" > gauge:<value:124 >  was collected before with the same name and label values

[pedrojimenez]

Any news ?

[metalmatze]

No news. Can you try to reproduce and send some instructions on how to do it? Maybe you might also want to create a PR? I don't have anything running into that problem myself at the moment.