Introduced RemoteRuntime wrapper in the agent#3227
Merged
Conversation
meowjesty
requested changes
Apr 2, 2025
Member
meowjesty
left a comment
There was a problem hiding this comment.
Small stuff. Only 1 I'm worried about is the missing pid from ephemeral, have you moved it to somewhere else?
Razz4780
added a commit
to Razz4780/mirrord
that referenced
this pull request
Apr 17, 2025
…o#3227)" (metalbear-co#3261) This reverts commit 8798707.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of spawning a new OS thread for each background task that needs access to the target's network, spawn just one, at agent startup. The thread runs a tokio runtime and spawns
Futures from fetched from anmpscchannel.Also, don't spawn extra threads when we don't need to join the target's network namespace: