Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modifying notes on checksum to reflect recent updates regarding empty checksumType field #497

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Modifying notes on checksum to reflect recent updates regarding empty checksumType field #497

wants to merge 1 commit into from

Conversation

fracappa
Copy link

Hi everyone.

As suggested by community members, I would like to propose those changes regarding checksumType notes to reflect modifications introduced in this PR.

The idea, is allowing the empty checksumType to behave the same way as the auto case.

This could be taken as a proposal for a new version of BMO (it could be 0.10.0).

Glad to receive any possible feedback.

Thanks.

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kashifest for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot
Copy link
Contributor

Hi @fracappa. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 17, 2025
tuminoid
tuminoid reviewed Jan 17, 2025
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

docs/user-guide/src/bmo/provisioning.md Outdated Show resolved Hide resolved
@metal3-io-bot metal3-io-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 17, 2025
@fracappa
Modifying notes on checksum to reflect recent updates regarding empty…
fe6db14 
… checksumType field

Signed-off-by: fracappa <[email protected]>

changing line length
dtantsur
dtantsur reviewed Feb 3, 2025
View reviewed changes
docs/user-guide/src/bmo/provisioning.md
of the BareMetalHost API.
Setting `checksumType` to `auto` or leaving it empty prompts Ironic to
automatically detect the checksum type based on its length and will become
the default in the next version of the BareMetalHost API.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last part is no longer relevant: the default in the next version will be the same as the default you introduced.

Instead, it may be useful to mention the version of BMO where the empty string works the same as auto.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know if it will be BMO v 0.10.0?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next version of BMO per milestones is v0.10.0. I don't think we're doing anything this release cycle to warrant major bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@dtantsur dtantsur dtantsur left review comments

@smoshiur1237 smoshiur1237 Awaiting requested review from smoshiur1237

Assignees
No one assigned
Labels
ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fracappa @metal3-io-bot @dtantsur @tuminoid