Skip to content

Properly manage libvirt services #1313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2023
Merged

Properly manage libvirt services #1313

merged 1 commit into from
Nov 14, 2023

Conversation

@cjeanner
Copy link
Contributor

@cjeanner cjeanner commented Nov 13, 2023

With newer CS9 and RHEL-9, libvirtd has moved to a modular, socket activated layout.

This new layout conflicts with the single, monolithic "libvirtd.service" that was restarted until now, creating issues with other projects that may wrap this metal3-dev-env.

Fixes: #1312

@metal3-io-bot metal3-io-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 13, 2023
@metal3-io-bot
Copy link
Collaborator

metal3-io-bot commented Nov 13, 2023

Hi @cjeanner. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 13, 2023
tuminoid
tuminoid reviewed Nov 13, 2023
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch!

Some nits that shellcheck will also probably point out.
/ok-to-test

@metal3-io-bot metal3-io-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 13, 2023
@cjeanner
Properly manage libvirt services
a6a7968 
With newer CS9 and RHEL-9, libvirtd has moved to a modular, socket
activated layout.

This new layout conflicts with the single, monolithic "libvirtd.service"
that was restarted until now, creating issues with other projects that
may wrap this metal3-dev-env.

Fixes: metal3-io#1312
@lentzi90
Copy link
Member

lentzi90 commented Nov 13, 2023

/test-centos-integration-release-1-5
/test-ubuntu-e2e-integration-main

lentzi90
lentzi90 reviewed Nov 13, 2023
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
/approve

@metal3-io-bot
Copy link
Collaborator

metal3-io-bot commented Nov 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2023
cjeanner added a commit to cjeanner/dev-scripts that referenced this pull request Nov 13, 2023
@cjeanner
Properly manage libvirt services
1b9d5d0 
With newer CS9 and RHEL-9, libvirtd has moved to a modular, socket
activated layout.

This new layout conflicts with the single, monolithic "libvirtd.service"
that was restarted until now, creating issues with other projects that
may wrap this metal3-dev-env.

There is a related PR against metal3-env-dev[1].

[1] metal3-io/metal3-dev-env#1313
This was referenced Nov 13, 2023
Merged
Closed
cjeanner added a commit to cjeanner/dev-scripts that referenced this pull request Nov 13, 2023
@cjeanner
Properly manage libvirt services
5a4dd09 
With newer CS9 and RHEL-9, libvirtd has moved to a modular, socket
activated layout.

This new layout conflicts with the single, monolithic "libvirtd.service"
that was restarted until now, creating issues with other projects that
may wrap this metal3-dev-env.

There is a related PR against metal3-env-dev[1].

[1] metal3-io/metal3-dev-env#1313
@cjeanner
Copy link
Contributor Author

cjeanner commented Nov 13, 2023

\o/ all green - that was almost too easy :).

@tuminoid
Copy link
Member

tuminoid commented Nov 14, 2023

/lgtm

Thanks for the contribution!

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 14, 2023
@metal3-io-bot metal3-io-bot merged commit 450bed5 into metal3-io:main Nov 14, 2023
@cjeanner cjeanner deleted the libvirt/modular branch November 14, 2023 07:49
cjeanner added a commit to cjeanner/dev-scripts that referenced this pull request Nov 15, 2023
@cjeanner
Properly manage libvirt services
d384436 
With newer CS9 and RHEL-9, libvirtd has moved to a modular, socket
activated layout.

This new layout conflicts with the single, monolithic "libvirtd.service"
that was restarted until now, creating issues with other projects that
may wrap this metal3-dev-env.

There is a related PR against metal3-env-dev[1].

[1] metal3-io/metal3-dev-env#1313
openshift-merge-bot bot pushed a commit to openshift-metal3/dev-scripts that referenced this pull request Nov 15, 2023
@cjeanner
Properly manage libvirt services (#1603)
e20da06 
With newer CS9 and RHEL-9, libvirtd has moved to a modular, socket
activated layout.

This new layout conflicts with the single, monolithic "libvirtd.service"
that was restarted until now, creating issues with other projects that
may wrap this metal3-dev-env.

There is a related PR against metal3-env-dev[1].

[1] metal3-io/metal3-dev-env#1313
@elfosardo
Copy link
Member

elfosardo commented Nov 16, 2023

this actually breaks execution of metal3-dev-env, see https://zuul.opendev.org/t/openstack/build/742fa43741ba4efca5d85c8c7c6a3d3b

@elfosardo
Copy link
Member

elfosardo commented Nov 16, 2023

fix proposed #1314

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tuminoid tuminoid tuminoid left review comments

+1 more reviewer

@lentzi90 lentzi90 lentzi90 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Properly manage modular libvirtd on rhel-9 and cs-9

5 participants

@cjeanner @metal3-io-bot @lentzi90 @tuminoid @elfosardo