Skip to content

Allow running ironic API, conductor and exporter separately#62

Merged
hardys merged 2 commits intometal3-io:masterfrom
dtantsur:split
Jul 8, 2019
Merged

Allow running ironic API, conductor and exporter separately#62
hardys merged 2 commits intometal3-io:masterfrom
dtantsur:split

Conversation

@dtantsur
Copy link
Copy Markdown
Member

We want to stop running several processes in one container, since it
violates container good practices and makes collecting logs and
health checking much harder.

We want to stop running several processes in one container, since it
violates container good practices and makes collecting logs and
health checking much harder.
@metal3ci
Copy link
Copy Markdown

Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/818/

Comment thread runironic-exporter.sh
. /bin/configure-ironic.sh

# TODO(dtantsur): merge these two scripts when/if we no longer support
# all-in-one container
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its not quite clear to me what this means, is this referring to when we use a different image for ironic-prometheus-exporter?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point I'd prefer to avoid adding any new images - we already have two critical tasks (machine-api-opearator integration of the baremetal operator, and cluster hosted ironic) blocked on getting forks of the existing images into openshift, adding any more right at this moment is likely to further delay things, which we really, really do need to avoid :)

That said we can start planning for new images to be used in future, but just not right now when those critical tasks are still pending.

@dtantsur
Copy link
Copy Markdown
Member Author

dtantsur commented Jul 1, 2019 via email

@dtantsur
Copy link
Copy Markdown
Member Author

dtantsur commented Jul 6, 2019

I'd like to merge this change this change since the CI works on it, and it alone is backward compatible with how things are run right now. Opinions?

Copy link
Copy Markdown
Member

@hardys hardys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok lgtm provided we expect to maintain backwards compatibility for now - provided this passes CI then I think we can go ahead and merge.

@metal3ci
Copy link
Copy Markdown

metal3ci commented Jul 8, 2019

Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/841/

@hardys hardys merged commit e52ba53 into metal3-io:master Jul 8, 2019
@dtantsur dtantsur deleted the split branch July 8, 2019 08:41
dtantsur pushed a commit to dtantsur/ironic-image that referenced this pull request Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants