Remove net-tools installation#248
Merged
metal3-io-bot merged 1 commit intometal3-io:masterfrom Mar 30, 2021
Merged
Conversation
metal3-io-bot
added
the
size/XS
dtantsur
requested changes
Mar 26, 2021
Member
dtantsur
left a comment
dtantsur
left a comment
There was a problem hiding this comment.
net-tools were installed for using netstat in scripts/runironic-api, that logic should also be removed
elfosardo
force-pushed
the
remove-command
branch
from
d8e9642 to
62258c2
Compare
dtantsur
reviewed
Mar 29, 2021
Now that metal3-io/baremetal-operator#728 has merged, we can remove net-tools installation command and the netstat entry in runironic-api.
elfosardo
force-pushed
the
remove-command
branch
from
62258c2 to
43d81c2
Compare
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur, elfosardo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
Member
|
/test-integration |
elfosardo
pushed a commit
to elfosardo/ironic-image
that referenced
this pull request
Jan 6, 2022
Bug 2032573: Update ironic to include latest major bugfixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that metal3-io/baremetal-operator#728 has
merged, we can remove net-tools installation command.