Skip to content

Replace IRONIC_IP in dnsmasq config#117

Merged
metal3-io-bot merged 1 commit intometal3-io:masterfrom
Nordix:dnsmasq-var-fix-mael
Dec 3, 2019
Merged

Replace IRONIC_IP in dnsmasq config#117
metal3-io-bot merged 1 commit intometal3-io:masterfrom
Nordix:dnsmasq-var-fix-mael

Conversation

@maelk
Copy link
Copy Markdown
Member

@maelk maelk commented Dec 3, 2019

the variable was not being replaced by sed

@maelk
Replace IRONIC_IP in dnsmasq config
134d576 
the variable was not being replaced by sed
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 3, 2019
@maelk
Copy link
Copy Markdown
Member Author

maelk commented Dec 3, 2019

/assign @hardys
/cc @stbenjam

@hardys hardys added the CI label Dec 3, 2019
@hardys
Copy link
Copy Markdown
Member

hardys commented Dec 3, 2019

lgtm but added the CI label just to be sure - interesting that this didn't result in broken deployments since e.g #107 passed the metal3 CI...

@metal3ci
Copy link
Copy Markdown

metal3ci commented Dec 3, 2019

Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1344/

@stbenjam
Copy link
Copy Markdown
Member

stbenjam commented Dec 3, 2019

CI failure unrelated.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2019
@maelk
Copy link
Copy Markdown
Member Author

maelk commented Dec 3, 2019

@hardys I think it passed the CI, because we do not use PXE, we use ipxe in the integration tests. there is no error there. If we were using pxe, it would be broken

@maelk
Copy link
Copy Markdown
Member Author

maelk commented Dec 3, 2019

/assign @juliakreger

@hardys
Copy link
Copy Markdown
Member

hardys commented Dec 3, 2019

/lgtm

@hardys
Copy link
Copy Markdown
Member

hardys commented Dec 3, 2019

/approve

@metal3-io-bot
Copy link
Copy Markdown
Contributor

metal3-io-bot commented Dec 3, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hardys, maelk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2019
@metal3-io-bot metal3-io-bot merged commit 372e25d into metal3-io:master Dec 3, 2019
@hardys hardys mentioned this pull request Dec 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stbenjam stbenjam Awaiting requested review from stbenjam

Assignees

@stbenjam stbenjam

@hardys hardys

@juliakreger juliakreger

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. CI lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@maelk @hardys @metal3ci @stbenjam @metal3-io-bot @juliakreger