Skip to content

Remove iptables filters from ironic containers#104

Merged
metal3-io-bot merged 1 commit intometal3-io:masterfrom
derekhiggins:no-iptables
Nov 25, 2019
Merged

Remove iptables filters from ironic containers#104
metal3-io-bot merged 1 commit intometal3-io:masterfrom
derekhiggins:no-iptables

Conversation

@derekhiggins
Copy link
Copy Markdown
Member

@derekhiggins derekhiggins commented Oct 10, 2019

We don't appear to need these, infact they output
errors on container startup...

@metal3-io-bot
Copy link
Copy Markdown
Contributor

metal3-io-bot commented Oct 10, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekhiggins

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 10, 2019
@derekhiggins
Copy link
Copy Markdown
Member Author

derekhiggins commented Oct 10, 2019

/hold
will run through ci once this merges openshift-metal3/dev-scripts#826

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 10, 2019
@metal3ci
Copy link
Copy Markdown

metal3ci commented Oct 11, 2019

Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1215/

@russellb
Copy link
Copy Markdown
Member

russellb commented Oct 12, 2019

Once it's working and you remove the hold, /lgtm

@russellb
Copy link
Copy Markdown
Member

russellb commented Oct 12, 2019

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2019
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2019
@metal3ci
Copy link
Copy Markdown

metal3ci commented Oct 16, 2019

Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1242/

@derekhiggins
Copy link
Copy Markdown
Member Author

derekhiggins commented Oct 17, 2019

/lgtm
ci failed in 12_csr_hack.sh

@metal3-io-bot
Copy link
Copy Markdown
Contributor

metal3-io-bot commented Oct 17, 2019

@derekhiggins: you cannot LGTM your own PR.

Details

In response to this:

/lgtm
ci failed in 12_csr_hack.sh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@derekhiggins
Copy link
Copy Markdown
Member Author

derekhiggins commented Oct 17, 2019

/hold cancel

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 17, 2019
@derekhiggins
Remove iptables filters from ironic containers
f380833 
We don't appear to need these, infact they output
errors on container startup...
@metal3ci
Copy link
Copy Markdown

metal3ci commented Nov 22, 2019

Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/1327/

@hardys
Copy link
Copy Markdown
Member

hardys commented Nov 25, 2019

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2019
@metal3-io-bot metal3-io-bot merged commit 9d8efc4 into metal3-io:master Nov 25, 2019
@hardys hardys mentioned this pull request Nov 25, 2019
Merged
hardys pushed a commit to hardys/ironic-image that referenced this pull request Nov 26, 2019
@derekhiggins
Remove iptables filters from ironic containers
c12aae7 
We don't appear to need these, infact they output
errors on container startup...

Related metal3-io change metal3-io#104
(cherry picked from commit f380833)
@hardys hardys mentioned this pull request Nov 26, 2019
Closed
@hardys hardys mentioned this pull request Dec 3, 2019
Closed
@hardys hardys mentioned this pull request Feb 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@russellb russellb

@hardys hardys

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. CI lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@derekhiggins @metal3-io-bot @metal3ci @russellb @hardys