This repository was archived by the owner on Mar 24, 2020. It is now read-only.
only set image and user data when we actually want to provision#94
Merged
dhellmann merged 4 commits intometal3-io:masterfrom Jul 2, 2019
dhellmann:conditionally-set-host-issue-93
Merged
only set image and user data when we actually want to provision#94dhellmann merged 4 commits intometal3-io:masterfrom dhellmann:conditionally-set-host-issue-93
dhellmann merged 4 commits intometal3-io:masterfrom
dhellmann:conditionally-set-host-issue-93
Conversation
Name the scenarios and use subtests to make it easier to see which output belongs with which failure.
We only want to update the image setting if the host does not already have a consumer and image. A consumer without an image is "externally provisioned" and assigning the image will trigger reprovisioning. Since the control plane nodes will be configured this way, reprovisioning will take them offline and try to turn them into workers. A host with an existing image is also already provisioned and upgrades are not supported at this time. To re-provision a host, we must fully deprovision it and then provision it again. Fixes #93
mhrivnak
approved these changes
Jul 2, 2019
Member
mhrivnak
left a comment
mhrivnak
left a comment
There was a problem hiding this comment.
LGTM. Should there also be something on the BMO side to enforce this? It seems like it should know that a host is provisioned, and in that case, not try to overwrite it without going through the formal deprovisioning workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We only want to update the image setting if the host does not already have
a consumer and image.
A consumer without an image is "externally provisioned" and assigning the
image will trigger reprovisioning. Since the control plane nodes will be
configured this way, reprovisioning will take them offline and try to turn
them into workers.
A host with an existing image is also already provisioned and upgrades are
not supported at this time. To re-provision ahost, we must fully deprovision
it and then provision it again.
Fixes #93