Skip to content

Add a unit test for unsupported secure boot #831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
metal3-io-bot merged 1 commit into from
Mar 26, 2021
Merged

Add a unit test for unsupported secure boot #831

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions pkg/provisioner/ironic/validatemanagementaccess_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -620,3 +620,29 @@ func TestValidateManagementAccessAddTwoHostsWithSameMAC(t *testing.T) {
assert.Equal(t, "", result.ErrorMessage)
assert.NotEqual(t, "", provID)
}

func TestValidateManagementAccessUnsupportedSecureBoot(t *testing.T) {
// Create a host without a bootMACAddress and with a BMC that
// requires one.
host := makeHost()
host.Spec.BootMode = metal3v1alpha1.UEFISecureBoot
host.Status.Provisioning.ID = "" // so we don't lookup by uuid

ironic := testserver.NewIronic(t).Ready().NoNode(host.Name)
ironic.Start()
defer ironic.Stop()

auth := clients.AuthConfig{Type: clients.NoAuth}
prov, err := newProvisionerWithSettings(host, bmc.Credentials{}, nil,
ironic.Endpoint(), auth, testserver.NewInspector(t).Endpoint(), auth,
)
if err != nil {
t.Fatalf("could not create provisioner: %s", err)
}

result, _, err := prov.ValidateManagementAccess(false, false)
if err != nil {
t.Fatalf("error from ValidateManagementAccess: %s", err)
}
assert.Contains(t, result.ErrorMessage, "does not support secure boot")
}