Skip to content

Fix some typos in PR292#809

Merged
metal3-io-bot merged 1 commit intometal3-io:masterfrom
zouy414:master
Mar 9, 2021
Merged

Fix some typos in PR292#809
metal3-io-bot merged 1 commit intometal3-io:masterfrom
zouy414:master

Conversation

@zouy414
Copy link
Member

@zouy414 zouy414 commented Mar 9, 2021

Signed-off-by: zouyu zouy.fnst@cn.fujitsu.com

This pr fixes a part of problems left in PR292.

Signed-off-by: zouyu <zouy.fnst@cn.fujitsu.com>
@metal3-io-bot metal3-io-bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 9, 2021
@metal3-io-bot
Copy link
Contributor

Hi @Hellcatlk. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@rdoxenham rdoxenham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this so quickly!

@rdoxenham
Copy link
Contributor

/lgtm

@metal3-io-bot
Copy link
Contributor

@rdoxenham: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andfasano
Copy link
Member

/test-integration

@andfasano
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 9, 2021
@hardys
Copy link
Member

hardys commented Mar 9, 2021

/ok-to-test
/approve

@metal3-io-bot metal3-io-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 9, 2021
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hardys, Hellcatlk, rdoxenham

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2021
@metal3-io-bot metal3-io-bot merged commit 0e68921 into metal3-io:master Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants