Add inspect.metal3.io=disabled annotation#787
Merged
metal3-io-bot merged 1 commit intometal3-io:masterfrom Feb 11, 2021
Merged
Conversation
When inspect.metal3.io=disabled is specified as an annotation we skip inspection and return complete immediately from the Inspecting state. Partially-Implements: metal3-io/metal3-docs#155
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hardys The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
metal3-io-bot
added
the
size/M
Member
Author
|
/test-integration |
hardys
commented
Feb 4, 2021
|
|
||
| if inspectionDisabled(info.host) { | ||
| info.log.Info("inspection disabled by annotation") | ||
| info.publishEvent("InspectionSkipped", "disabled by annotation") |
Member
Author
There was a problem hiding this comment.
I added an event so it's clearer in the event output e.g:
Events:
Type Reason Age From Message
---- ------ ---- ---- -------
Normal Registered 13m metal3-baremetal-controller Registered new host
Normal BMCAccessValidated 13m metal3-baremetal-controller Verified access to BMC
Normal InspectionSkipped 13m metal3-baremetal-controller disabled by annotation
Normal ProfileSet 13m metal3-baremetal-controller Hardware profile set: unknown
Normal PowerOn 13m metal3-baremetal-controller Host powered on
Member
|
/lgtm |
hardys
pushed a commit
to hardys/dev-scripts
that referenced
this pull request
Feb 19, 2021
To enable testing with the changes implemented in metal3-io/baremetal-operator#787 This requires an OCP build which contains this rebase openshift/baremetal-operator#125
hardys
pushed a commit
to hardys/dev-scripts
that referenced
this pull request
Feb 22, 2021
To enable testing with the changes implemented in metal3-io/baremetal-operator#787 This requires an OCP build which contains this rebase openshift/baremetal-operator#125
hardys
pushed a commit
to hardys/dev-scripts
that referenced
this pull request
Feb 25, 2021
To enable testing with the changes implemented in metal3-io/baremetal-operator#787 This requires an OCP build which contains this rebase openshift/baremetal-operator#125
hardys
pushed a commit
to hardys/dev-scripts
that referenced
this pull request
Feb 25, 2021
To enable testing with the changes implemented in metal3-io/baremetal-operator#787 This requires an OCP build which contains this rebase openshift/baremetal-operator#125
hardys
pushed a commit
to hardys/dev-scripts
that referenced
this pull request
Mar 2, 2021
To enable testing with the changes implemented in metal3-io/baremetal-operator#787 This requires an OCP build which contains this rebase openshift/baremetal-operator#125
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When inspect.metal3.io=disabled is specified as an annotation we skip
inspection and return complete immediately from the Inspecting state.
Partially-Implements: metal3-io/metal3-docs#155