Wait for inspection completion

[andfasano]

The previous logic for Provisioner.InspectHardware() considered the action completed by just looking at the Inspector result flags Finished and Error. Anyhow, even though the inspection was effectively completed, there could be some cases where the related node Provisioning state was still in inspectWait since the update in Ironic is not simultaneous.
This could be a problem since the BMO state machine goes on and some BMO states could report an error if the node is not in the expected provisioning state (as the new Preparing state introduced in #763).

This PR so waits also for the node to not be in inspectWait before considering the inspection successfully done.

/cc @dtantsur @zaneb @Hellcatlk

[metal3-io-bot]

@andfasano: GitHub didn't allow me to request PR reviews from the following users: Hellcatlk.

Note that only metal3-io members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

The previous logic for Provisioner.InspectHardware() considered the action completed by just looking at the Inspector result flags Finished and Error. Anyhow, even though the inspection was effectively completed, there could be some cases where the related node Provisioning state was still in inspectWait since the update in Ironic is not simultaneous.
This could be a problem since the BMO state machine goes on and some BMO states could report an error if the node is not in the expected provisioning state (as the new Preparing state introduced in #763).

This PR so waits also for the node to not be in inspectWait before considering the inspection successfully done.

/cc @dtantsur @zaneb @Hellcatlk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[zaneb]

/approve

[metal3-io-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano, dtantsur, elfosardo, zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [zaneb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[elfosardo]

/test-integration

[hardys]

/lgtm