Ask Ironic to include NodeUUID when querying ports#776
Merged
metal3-io-bot merged 1 commit intometal3-io:masterfrom Jan 26, 2021
Merged
Ask Ironic to include NodeUUID when querying ports#776metal3-io-bot merged 1 commit intometal3-io:masterfrom
metal3-io-bot merged 1 commit intometal3-io:masterfrom
Conversation
metal3-io-bot
added
the
size/XS
Member
|
Seems reasonable to me /approve |
metal3-io-bot
added
the
approved
Member
|
/test-integration |
dtantsur
approved these changes
Jan 22, 2021
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur, honza, stbenjam, zaneb The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
When registering a new host, we check if its bootMACAddress conflicts with any existing Ironic nodes. This procedure queries Ironic ports, and if a port is found, we use the port's NodeUUID to find the conflicting node. However, we are using `ports.List()` which only returns minimal resources by default; e.g. any returned ports will have their NodeUUID property set to an empty string. We are now explicitly asking for Ironic to include the `node_uuid` field. We also adjust the mock test mechanism to account for this.
honza
changed the title
Member
|
/test-integration |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When registering a new host, we check if its bootMACAddress conflicts
with any existing Ironic nodes. This procedure queries Ironic ports,
and if a port is found, we use the port's NodeUUID to find the
conflicting node. However, we are using
ports.List()which onlyreturns minimal resources by default; e.g. any returned ports will have
their NodeUUID property set to an empty string.
We are now explicitly asking for Ironic to include the
node_uuidfield.
We also adjust the mock test mechanism to account for this.