Add test coverage of Spec vs Status Image#770
Merged
metal3-io-bot merged 1 commit intometal3-io:masterfrom Jan 20, 2021
Merged
Conversation
As seen in the regression CI discovered that prompted metal3-io#768 we're missing some test coverage of the two possible image sources in ValidateManagementAccess
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hardys The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
metal3-io-bot
added
the
size/M
Member
Author
|
/test-integration |
Member
Author
|
/cc @zaneb - this adds test coverage for the use-provisioned-image-data change introduced via #716 - hopefully it'll catch regressions like the one I introduced ref #768 more quickly next time. |
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As seen in the regression CI discovered that prompted
#768
we're missing some test coverage of the two possible
image sources in ValidateManagementAccess