Skip to content

WIP Revert "ironic provisioner de-duplicate image options"#767

Closed
hardys wants to merge 1 commit intometal3-io:masterfrom
hardys:liveimage2_revert
Closed

WIP Revert "ironic provisioner de-duplicate image options"#767
hardys wants to merge 1 commit intometal3-io:masterfrom
hardys:liveimage2_revert

Conversation

@hardys
Copy link
Copy Markdown
Member

@hardys hardys commented Jan 18, 2021

This reverts commit 177d9ef.

Conflicts:
pkg/provisioner/ironic/ironic.go

@metal3-io-bot metal3-io-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 18, 2021
@metal3-io-bot
Copy link
Copy Markdown
Contributor

metal3-io-bot commented Jan 18, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hardys

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 18, 2021
@hardys
Copy link
Copy Markdown
Member Author

hardys commented Jan 18, 2021

/hold just to verify if this helps with CI issues recently observed

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 18, 2021
Revert "ironic provisioner de-duplicate image options"
906e90b 
This reverts commit 177d9ef.

Conflicts:
  pkg/provisioner/ironic/ironic.go
@hardys hardys force-pushed the liveimage2_revert branch from cf7b66a to 906e90b Compare January 18, 2021 15:49
@fmuyassarov
Copy link
Copy Markdown
Member

fmuyassarov commented Jan 18, 2021

/test-v1a3-centos-integration

@zaneb
Copy link
Copy Markdown
Member

zaneb commented Jan 18, 2021

Testing confirms that this patch was indeed the problem. Should be fixed by #768
/close

@metal3-io-bot
Copy link
Copy Markdown
Contributor

metal3-io-bot commented Jan 18, 2021

@zaneb: Closed this PR.

Details

In response to this:

Testing confirms that this patch was indeed the problem. Should be fixed by #768
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hardys @metal3-io-bot @fmuyassarov @zaneb