Handle dual-stack configuration in inspection data

[hardys]

Currently we assume only an ipv4 or an ipv6 IP exists in the
inspection data, but it's valid for both to exist in a dual-stack
scenario.

To avoid changing the BMH API, in this case we create an additional
nic entry in the list, which will contain each IP but otherwise
the same data.

Fixes: #458

[stbenjam]

/test-integration

[hardys]

Tested in a dual-stack environment and this does work as expected:

    hostname: worker-0
    nics:
    - ip: 192.168.111.23
      mac: 00:8a:dc:db:c7:f1
      model: 0x1af4 0x0001
      name: enp2s0
      pxe: false
      speedGbps: 0
      vlanId: 0
    - ip: fd2e:6f44:5dd8:c956::1f
      mac: 00:8a:dc:db:c7:f1
      model: 0x1af4 0x0001
      name: enp2s0
      pxe: false
      speedGbps: 0
      vlanId: 0

[hardys]

/test-integration

[dhellmann]

This version looks good.

/approve

[hardys]

This version looks good.

Thanks - I just pushed a minor update to the test (I forgot to compare the value for the NoIp nic added in the previous revision)

[bfournie]

Do you think description here needs to change to indicate a 2nd nic will be used for dual-stack? https://github.com/metal3-io/baremetal-operator/blob/master/config/crd/bases/metal3.io_baremetalhosts.yaml#L343

[hardys]

Do you think description here needs to change to indicate a 2nd nic will be used for dual-stack? https://github.com/metal3-io/baremetal-operator/blob/master/config/crd/bases/metal3.io_baremetalhosts.yaml#L343

Good point, thanks! I'll push another commit which clarifies that.

[hardys]

/test-integration

[metal3-io-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bfournie, dhellmann, hardys

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [dhellmann,hardys]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[stbenjam]

/lgtm