Fix issues with deprovisioning after an error/failover#745
Merged
metal3-io-bot merged 2 commits intometal3-io:masterfrom Jan 20, 2021
Merged
Fix issues with deprovisioning after an error/failover#745metal3-io-bot merged 2 commits intometal3-io:masterfrom
metal3-io-bot merged 2 commits intometal3-io:masterfrom
Conversation
metal3-io-bot
added
approved
Member
Author
|
/test-integration |
dhellmann
approved these changes
Jan 5, 2021
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhellmann, zaneb The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
|
/test-integration |
If provisioning fails and the node ends up in the deploy failed state, we try to recover by deprovisioning. That would work better if we actually handled deploy failed in Deprovision().
In the deprovisioning state, calling Adopt() on a freshly-reregistered host will fail if we didn't previously complete provisioning because there will be no image data stored in the status to pass to the node for adoption. Only call Adopt() if the previous provisioning completed and recorded the requisite image data. If the node has just been re-registered, it will be in the manageable state anyway, and thus will still get cleaned before it is next provisioned.
Member
Author
|
/test-integration |
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If provisioning fails and the node ends up in the
deploy failedstate,we try to recover by deprovisioning. That would work better if we
actually handled
deploy failedinDeprovision().Only call
Adopt()if the previous provisioning completed and recordedthe requisite image data.