Skip to content

[doc nit] Fix section header "install operator-sdk"#652

Closed
asalkeld wants to merge 1 commit intometal3-io:masterfrom
asalkeld:docs-nit
Closed

[doc nit] Fix section header "install operator-sdk"#652
asalkeld wants to merge 1 commit intometal3-io:masterfrom
asalkeld:docs-nit

Conversation

@asalkeld
Copy link
Copy Markdown
Contributor

No description provided.

@metal3-io-bot metal3-io-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 25, 2020
@metal3-io-bot
Copy link
Copy Markdown
Contributor

Hi @asalkeld. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@honza
Copy link
Copy Markdown
Member

honza commented Sep 25, 2020

/ok-to-test
/lgtm

@metal3-io-bot metal3-io-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 25, 2020
@dhellmann
Copy link
Copy Markdown
Member

/approve

@metal3-io-bot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asalkeld, dhellmann

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2020
@metal3-io-bot
Copy link
Copy Markdown
Contributor

@asalkeld: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
generate 49d032c link /test generate
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@asalkeld
Copy link
Copy Markdown
Contributor Author

generate error is:

/bin/sh: 1: openapi-gen: not found

@maelk
Copy link
Copy Markdown
Member

maelk commented Sep 28, 2020

yes, that is because we changed the jobs to adapt for #655 that needs to go in first.

@asalkeld
Copy link
Copy Markdown
Contributor Author

asalkeld commented Oct 1, 2020

obsolete

@asalkeld asalkeld closed this Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants