Migrate to Go modules by honza · Pull Request #367 · metal3-io/baremetal-operator

honza · 2019-12-16T11:31:54Z

Steps taken:

Run dep ensure to make sure that the vendor directory is up-to-date
Run go mod init ... to create Go module files
Run tests, build, etc to make sure everything works
Upgrade local operator-sdk cli tool to the latest version
Update requires by hand in go.mod
Tests, lint, etc all pass
Remove vendor directory
Remove references to dep tool from Makefile

Official migrating to Go modules documentation

zaneb · 2019-12-19T18:42:36Z

What's the thinking behind re-adding the vendor directory? From what I read this is only for compatibility with non-module-aware versions of Go?

honza · 2019-12-23T10:18:00Z

What's the thinking behind re-adding the vendor directory?

The idea is that CI doesn't have to download all the module files.

zaneb · 2020-01-13T18:40:29Z

OK, that sounds reasonable.
/lgtm
/test-v1a1-integration

zaneb · 2020-01-15T15:28:53Z

/test-centos-integration

zaneb · 2020-01-15T17:43:20Z

/test-centos-integration

zaneb · 2020-01-17T04:03:55Z

/test-centos-integration

zaneb · 2020-01-21T23:45:20Z

/lgtm

metal3-io-bot · 2020-02-03T20:05:24Z

New changes are detected. LGTM label has been removed.

honza · 2020-02-03T20:21:21Z

Updated to use operator-sdk 0.15.1.

~~Currently blocked by metal3-io/project-infra#50~~

honza · 2020-02-03T20:24:20Z

More context:

The current Prow job uses Go 1.12; this version doesn't automatically detect go modules. The next version, 1.13 does. All jobs which use the go binary will fail because it can't find the necessary dependencies (it's blind to the go.mod and go.sum file). With 1.13, the go command will see the go.mod file, and download the necessary packages.

We are migrating to use go modules because the operator-sdk forces us to.

zaneb · 2020-02-03T21:51:39Z

The current Prow job uses Go 1.12; this version doesn't automatically detect go modules.

Surely that's just a matter of setting the environment variable GO111MODULE=on?

honza · 2020-02-03T22:34:24Z

Surely that's just a matter of setting the environment variable GO111MODULE=on?

Yes.

But 1.13.x is the latest stable?

honza · 2020-02-03T22:55:25Z

It seems that the canned jobs don't use our Makefile so I'm not sure how I can set the envvar in them.

honza · 2020-02-19T13:32:46Z

/retest

honza · 2020-02-20T02:28:45Z

/retest

stbenjam · 2020-02-21T13:50:53Z

/test-integration

honza · 2020-02-26T11:56:58Z

/test-integration

This was recently changed, and this seems to be a left behind by accident.

honza · 2020-02-26T12:57:04Z

/test-integration

honza · 2020-02-26T13:43:24Z

/test gofmt

honza · 2020-02-26T18:57:22Z

/test-integration

stbenjam · 2020-02-26T20:11:30Z

/approve

metal3-io-bot · 2020-02-26T20:12:08Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: honza, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [stbenjam]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

zaneb · 2020-02-27T16:19:50Z

This looks good.
I guess the ideal in a situation like this would be to separate out the change from dep->go mod from any version changes in dependencies. It seems like that wasn't possible in this case, and I don't want to ask you to go back and start again because it's hard enough to get anything passing all of CI!
In lieu of that, can I suggest that we document somewhere all of the dependencies that actually changed? golang and the operator-sdk seem to be two of them.
Are there any changes to checked-in generated code resulting from updating the operator-sdk?

honza · 2020-02-27T18:14:44Z

and I don't want to ask you to go back and start again

I am a git wizard 😎 I can move some commits around.

I tried to make everything explicit in #444

Downgrade operator-sdk to 0.11
Migrate to go modules
Remove vendor and Gopkg
Upgrade operator-sdk to 0.15
Update build settings (docker, makefile, etc)

The commit messages in the new PR are much more explicit about what's going on.

honza · 2020-02-27T19:31:03Z

Closing in favor of #444

OCPBUGS-36425: Sync jul 30

metal3-io-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 16, 2019

honza force-pushed the go-modules branch from 38014d3 to eef3803 Compare December 16, 2019 13:01

zaneb mentioned this pull request Jan 13, 2020

Modify Makefile to install operator-sdk v0.12.0 if not installed #349

Closed

metal3-io-bot assigned zaneb Jan 13, 2020

metal3-io-bot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Jan 13, 2020

honza force-pushed the go-modules branch from 50a55e2 to 45d4f27 Compare January 15, 2020 16:00

metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2020

honza force-pushed the go-modules branch from 45d4f27 to 1d5c7d9 Compare February 3, 2020 20:05

metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2020

honza mentioned this pull request Feb 19, 2020

operator-sdk generate openapi breaks with operator-sdk>=0.12 #434

Closed

19 tasks

dhellmann mentioned this pull request Feb 21, 2020

Unit test broken #433

Closed

kirankt mentioned this pull request Feb 24, 2020

Fix dep check in Makefile #441

Closed

honza added 9 commits February 26, 2020 08:45

Use dep-status instead of dep-check in test target

a262f61

This was recently changed, and this seems to be a left behind by accident.

Add go module files

4a3d438

Remove vendor directory

3278b7a

Remove references to "dep" from Makefile

c45536c

Remove Gopkg files

7ad648f

Set GO111MODULE to on in Makefile

8e9311e

Update travis to use go modules

96294f0

Update dockerfile to build from golang 1.13

5c495a3

Unset GOFLAGS

e188125

honza force-pushed the go-modules branch from f55f581 to e188125 Compare February 26, 2020 12:46

Export cache dir in gofmt

5844eb1

metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2020

This was referenced Feb 27, 2020

Go modules, take 2 #443

Closed

Go modules, take 2 #444

Merged

honza closed this Feb 27, 2020

dtantsur pushed a commit to dtantsur/baremetal-operator that referenced this pull request Aug 6, 2024

Merge pull request metal3-io#367 from iurygregory/sync-jul-30

054be80

OCPBUGS-36425: Sync jul 30

Conversation

honza commented Dec 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zaneb commented Dec 19, 2019

Uh oh!

honza commented Dec 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zaneb commented Jan 13, 2020

Uh oh!

zaneb commented Jan 15, 2020

Uh oh!

zaneb commented Jan 15, 2020

Uh oh!

zaneb commented Jan 17, 2020

Uh oh!

zaneb commented Jan 21, 2020

Uh oh!

metal3-io-bot commented Feb 3, 2020

Uh oh!

honza commented Feb 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

honza commented Feb 3, 2020

Uh oh!

zaneb commented Feb 3, 2020

Uh oh!

honza commented Feb 3, 2020

Uh oh!

honza commented Feb 3, 2020

Uh oh!

honza commented Feb 19, 2020

Uh oh!

honza commented Feb 20, 2020

Uh oh!

stbenjam commented Feb 21, 2020

Uh oh!

honza commented Feb 26, 2020

Uh oh!

honza commented Feb 26, 2020

Uh oh!

honza commented Feb 26, 2020

Uh oh!

honza commented Feb 26, 2020

Uh oh!

stbenjam commented Feb 26, 2020

Uh oh!

metal3-io-bot commented Feb 26, 2020

Uh oh!

zaneb commented Feb 27, 2020

Uh oh!

honza commented Feb 27, 2020

Uh oh!

honza commented Feb 27, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

honza commented Dec 16, 2019 •

edited

Loading

honza commented Dec 23, 2019 •

edited

Loading

honza commented Feb 3, 2020 •

edited

Loading