Adding code-generator for Kubernetes-style API#361
Conversation
|
Hi @longkb. Thanks for your PR. I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR aims to add `code-generator` again in order to run `make generate` as reported in metal3-io#360 Signed-off-by: Kim Bao Long <longkb@vn.fujitsu.com>
|
/ok-to-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: longkb, zaneb The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @zaneb :) |
Thanks. It worked with $ make test
operator-sdk generate k8s
INFO[0000] Running deepcopy code-generation for Custom Resource group versions: [metal3:[v1alpha1], ]
INFO[0001] Code-generation complete.
operator-sdk generate openapi
INFO[0000] Running OpenAPI code-generation for Custom Resource group versions: [metal3:[v1alpha1], ]
Error: error generating CRD for Group metal3 Version v1alpha1 Kind BareMetalHost
Usage:
operator-sdk generate openapi [flags]
Flags:
-h, --help help for openapi
Global Flags:
--verbose Enable verbose logging
Makefile:41: recipe for target 'generate' failed
make: *** [generate] Error 1
|
|
Hi @longkb. What is the status with this PR ? Should it be closed or should it make its way to master ? |
This PR aims to add
code-generatoragain in order to runmake generateas reported in #360Signed-off-by: Kim Bao Long longkb@vn.fujitsu.com