Skip to content

Adding code-generator for Kubernetes-style API#361

Closed
longkb wants to merge 1 commit into
metal3-io:masterfrom
longkb:readd_code_generator
Closed

Adding code-generator for Kubernetes-style API#361
longkb wants to merge 1 commit into
metal3-io:masterfrom
longkb:readd_code_generator

Conversation

@longkb
Copy link
Copy Markdown
Contributor

@longkb longkb commented Dec 9, 2019

This PR aims to add code-generator again in order to run make generate as reported in #360

Signed-off-by: Kim Bao Long longkb@vn.fujitsu.com

@metal3-io-bot
Copy link
Copy Markdown
Contributor

Hi @longkb. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 9, 2019
This PR aims to add `code-generator` again in order to run `make generate` as reported in metal3-io#360

Signed-off-by: Kim Bao Long <longkb@vn.fujitsu.com>
@zaneb
Copy link
Copy Markdown
Member

zaneb commented Dec 9, 2019

/ok-to-test
/approve

@metal3-io-bot metal3-io-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 9, 2019
@metal3-io-bot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: longkb, zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2019
@longkb
Copy link
Copy Markdown
Contributor Author

longkb commented Dec 12, 2019

/ok-to-test
/approve

Thanks @zaneb :)
It seems that we need /lgtm label for tide

@maelk
Copy link
Copy Markdown
Member

maelk commented Dec 12, 2019

@longkb, is it because of using a version of operator-sdk that is not up to date ? Please check #349

@longkb
Copy link
Copy Markdown
Contributor Author

longkb commented Dec 13, 2019

@longkb, is it because of using a version of operator-sdk that is not up to date ? Please check #349

Thanks. It worked with operator-sdk v.0.12.0. I will close this PR :)
But when I tried with my patch (#292), I reach another error related to openapi

$ make test
operator-sdk generate k8s
INFO[0000] Running deepcopy code-generation for Custom Resource group versions: [metal3:[v1alpha1], ]
INFO[0001] Code-generation complete.
operator-sdk generate openapi
INFO[0000] Running OpenAPI code-generation for Custom Resource group versions: [metal3:[v1alpha1], ]
Error: error generating CRD for Group metal3 Version v1alpha1 Kind BareMetalHost
Usage:
  operator-sdk generate openapi [flags]

Flags:
  -h, --help   help for openapi

Global Flags:
      --verbose   Enable verbose logging

Makefile:41: recipe for target 'generate' failed
make: *** [generate] Error 1

@maelk
Copy link
Copy Markdown
Member

maelk commented Jan 23, 2020

Hi @longkb. What is the status with this PR ? Should it be closed or should it make its way to master ?

@longkb
Copy link
Copy Markdown
Contributor Author

longkb commented Jan 30, 2020

Hi @longkb. What is the status with this PR ? Should it be closed or should it make its way to master ?

Hi @maelk ,
We just have a long holiday :). I will close this PR now

@longkb longkb closed this Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants