Add idrac redfish virtual media bmc support#359
Merged
metal3-io-bot merged 3 commits intometal3-io:masterfrom Dec 9, 2019
Merged
Add idrac redfish virtual media bmc support#359metal3-io-bot merged 3 commits intometal3-io:masterfrom
metal3-io-bot merged 3 commits intometal3-io:masterfrom
Conversation
metal3-io-bot
added
the
size/M
Member
|
/approve |
metal3-io-bot
added
the
approved
stbenjam
reviewed
Dec 6, 2019
honza
force-pushed
the
idrac-redfish-vm
branch
from
d6ce69e to
fe16d03
Compare
metal3-io-bot
added
size/L
honza
force-pushed
the
idrac-redfish-vm
branch
from
fe16d03 to
237c8bc
Compare
zaneb
reviewed
Dec 6, 2019
|
|
||
| func (a *redfishAccessDetails) InspectInterface() string { | ||
| if a.isiDrac { | ||
| return "inspector" |
Member
There was a problem hiding this comment.
Docs suggest we should use idrac-redfish here in order to use Redfish, as opposed to the default idrac-wsman.
In practice, however, I suspect we actually want to pass inspector for every driver and not have an InspectInterface() method in AccessDetails at all. @dtantsur can you confirm?
honza
force-pushed
the
idrac-redfish-vm
branch
from
b51eb23 to
b4e0042
Compare
zaneb
reviewed
Dec 6, 2019
zaneb
reviewed
Dec 6, 2019
honza
force-pushed
the
idrac-redfish-vm
branch
from
b4e0042 to
5ef0214
Compare
stbenjam
reviewed
Dec 9, 2019
honza
force-pushed
the
idrac-redfish-vm
branch
from
5ef0214 to
2b49cf9
Compare
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: honza, zaneb The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
Looks good to me, thanks @honza! I got a good local test with metal3-dev-env using these changes, as well. /lgtm |
dtantsur
pushed a commit
to dtantsur/baremetal-operator
that referenced
this pull request
Aug 26, 2024
…ry-pick-358-to-release-4.14 [release-4.14] OCPBUGS-34814: PreprovisioningImage should not be created on poweroff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.