Skip to content

Avoid port conflict for metrics endpoint#253

Merged
russellb merged 1 commit intometal3-io:masterfrom
hardys:port_conflict
Jul 9, 2019
Merged

Avoid port conflict for metrics endpoint#253
russellb merged 1 commit intometal3-io:masterfrom
hardys:port_conflict

Conversation

@hardys
Copy link
Copy Markdown
Member

@hardys hardys commented Jul 9, 2019

In the OpenShift integrated case this conflicts with coredns which binds
to :::8080, switching to 8085 should avoid this conflict with the
default.

Fixes: #252

In the OpenShift integrated case this conflicts with coredns which binds
to :::8080, switching to 8085 should avoid this conflict with the
default.

Fixes: metal3-io#252
@russellb russellb merged commit 89a0967 into metal3-io:master Jul 9, 2019
Copy link
Copy Markdown
Member

@dhellmann dhellmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hardys
Copy link
Copy Markdown
Member Author

hardys commented Jul 9, 2019

Ah thanks @dhellmann I wasn't sure how the ports were assigned so I just chose one which was free in my test environment ;)

Seems we need to add the ironic exporter to https://github.com/prometheus/prometheus/wiki/Default-port-allocations then update this again

@russellb
Copy link
Copy Markdown
Member

russellb commented Jul 9, 2019

Ah thanks @dhellmann I wasn't sure how the ports were assigned so I just chose one which was free in my test environment ;)

Seems we need to add the ironic exporter to https://github.com/prometheus/prometheus/wiki/Default-port-allocations then update this again

Hmm, that page seems to be aimed at exporters. I've added the Ironic Prometheus Exporter, though.

honza pushed a commit to honza/baremetal-operator that referenced this pull request Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

metrics endpoint has port conflict

3 participants