Changes tests to use karma instead of mocha #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just started reviewing :) |
Sent from 
This converts all existing test files to run through karma, except these: (1) Tests for `html` directory -> These tests rely on fetching files, which can't be done through karma. (2) Tests for `webchannel` and `net` directories. These require some fixture files that are being requested through a `require` call. A follow up commit will change these to work on karma appropriately as well.
Running them through PhantomJS. PhantomJS currently doesn't support classList add/remove with multiple arguments, so I've changed our code to pass one at a time for now. Later we can see what we'll do about PhantomJS.
|
Thank you, pull request merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.