Escapes html entities inside element attributes #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, I'm curious, what kind of issues did you get before adding this? XSS? |
|
This was actually causing https://issues.liferay.com/browse/LPS-82527, because we render html, into a js string and back to html, and then we were double-escaping the actionURL of the form |
|
Ah. Got it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @eduardolundgren, @brunobasto, what do you think about this? We aren't properly unescaping attribute values before passing it down to incremental-dom, which is causing some complex issues.
I think this should be safe since all tests are passing and I added an additional one... 🤔
/cc @topolik