Prevents Closure Library (goog) and IncrementalDOM from being evaluated more than once in the same page #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are failing because of the 'querySelectorAll' called on an object that does not implement interface DocumentFragment.
D.querySelectorAll@packages/metal-web-component/node_modules/@webcomponents/webcomponentsjs/webcomponents-lite.js:91:362
querySelectorAll@packages/metal-web-component/node_modules/@webcomponents/webcomponentsjs/webcomponents-lite.js:145:224
matchFallback_@/tmp/packages/metal-dom/src/domNamed.js:441:15 <- /tmp/f31d2ff061dd32678dcd82f2224bb927.browserify:8779:14
match@/tmp/packages/metal-dom/src/domNamed.js:429:8 <- /tmp/f31d2ff061dd32678dcd82f2224bb927.browserify:8767:9 |
eduardolundgren
changed the title
jbalsas
force-pushed
the
soy_bundle_dedupe
branch
from
cc10b43 to
7df61f8
Compare
jbalsas
changed the title
…ed more than once in the same page Both Closure Library (goog) and IncrementalDOM populate the global context. To prevent errors and keep both libraries in sync, we just allow the first execution in a single page to register in the global context.
jbalsas
force-pushed
the
soy_bundle_dedupe
branch
from
7df61f8 to
217229a
Compare
jbalsas
changed the title
…lid standard signature This was causing a problem with polyfills such as webcomponents were querySelectorAll takes a second parameter that changes the meaning of the method and makes it fail under certain conditions
jbalsas
force-pushed
the
soy_bundle_dedupe
branch
from
217229a to
26790e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.