Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds a range validator #333

Merged
merged 2 commits into from
Jan 11, 2018
Merged

Adds a range validator #333

merged 2 commits into from
Jan 11, 2018

Conversation

julien
Copy link
Contributor

@julien julien commented Jan 10, 2018 •
edited by brunobasto
Loading

Hey @julien! Looks like an useful validator! Just wondering about the name. Do you think perhaps .inRange() would be more clear?

@julien
Copy link
Contributor Author

julien commented Jan 10, 2018

Hey @brunobasto,
Thanks! Yes .inRange() seems better. I'll update that.

@brunobasto
Copy link

Looks like you figured things on your own 🤣

@robframpton
Copy link

Rerunning CI.

@robframpton robframpton changed the base branch from master to develop January 11, 2018 01:48
robframpton
robframpton approved these changes Jan 11, 2018
View reviewed changes
Copy link

@robframpton robframpton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@robframpton robframpton merged commit ecedaa0 into metal:develop Jan 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robframpton robframpton robframpton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julien @brunobasto @robframpton