Adds Fragment component #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Rerunning CI. |
robframpton
approved these changes
Jan 2, 2018
|
Hey @bryceosterhaus When you get a chance, can you add a short section to https://metaljs.com/docs/guides/jsx-components.html documenting this feature? |
|
@Robert-Frampton bryceosterhaus/metaljs.com#89 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were going to add this to our specific project but then figured it would be really useful for the project. Idea came from https://reactjs.org/blog/2017/11/28/react-v16.2.0-fragment-support.html.
I wanted to some how blacklist all props passed in except for
keyandchildren, but I couldn't think of a clean way of doing so. So in the mean time, I thought smaller fix for that was a custom validator that threw a warning on the component itself.Let me know what you think