Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Method calls to Config helpers should return new objects to avoid unintended mutation #311

Merged
merged 2 commits into from
Nov 29, 2017
Merged

Method calls to Config helpers should return new objects to avoid unintended mutation #311

merged 2 commits into from
Nov 29, 2017

Conversation

robframpton
Copy link

No description provided.

@robframpton robframpton mentioned this pull request Nov 28, 2017
Closed
jbalsas
jbalsas approved these changes Nov 29, 2017
View reviewed changes
Copy link
Contributor

@jbalsas jbalsas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on the feedback from #310

@jbalsas jbalsas merged commit 82913d7 into metal:develop Nov 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbalsas jbalsas jbalsas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robframpton @jbalsas