Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run test:saucelabs script on CI #307

Merged
merged 6 commits into from
Nov 22, 2017
Merged

Run test:saucelabs script on CI #307

merged 6 commits into from
Nov 22, 2017

Conversation

robframpton
Copy link

No description provided.

Copy link
Contributor

@jbalsas jbalsas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Robert-Frampton, I'm going to merge since this is a step in the right direction :D

I see we're still using gulp to run metal-tools-soy. Are you planning on getting rid of that as well and rely on npm scripts only on a different PR?

@jbalsas jbalsas merged commit 46a2d06 into metal:develop Nov 22, 2017
@robframpton
Copy link
Author

robframpton commented Nov 22, 2017

Hey @jbalsas

I left it because the gulp portion isn't just compiling the soy, but it's also modifying some paths. Gulp is not a bad tool for doing things like this, so I didn't see the need in changing it at this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants